feat: add pwa to projectshut #2044

SubhamB2003 · 2023-08-09T18:12:53Z

Related Issue

solves #2028

@priyankarpal Can you please review my pr as tomorrow the event ended?

Description

Screenshots

Installed in my desktop

vercel · 2023-08-09T18:12:57Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
projectshut	✅ Ready (Inspect)	Visit Preview	Aug 10, 2023 9:12am

github-actions

Great job, @SubhamB2003! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

priyankarpal · 2023-08-09T18:25:59Z

@SubhamB2003 please use pnpm install --no-frozen-lockfile

priyankarpal

create a image folder & put images in there or try to use cdn link

SubhamB2003 · 2023-08-09T18:32:33Z

create a image folder & put images in there or try to use cdn link

Hey, actually the images are needed for manifest logos. that's why I did not use any CDN

priyankarpal · 2023-08-09T18:34:27Z

create a image folder & put images in there or try to use cdn link

Hey, actually the images are needed for manifest logos. that's why I did not use any CDN

ok

also, I think we need to add

 /public/sw.js**
 /public/workbox-*.js**
 /public/worker-*.js**
 /public/sw.js.map**
 /public/workbox-*.js.map**
 /public/worker-*.js.map

to the gitignore

SubhamB2003 · 2023-08-09T18:38:07Z

create a image folder & put images in there or try to use cdn link

Hey, actually the images are needed for manifest logos. that's why I did not use any CDN

ok

also, I think we need to add
 /public/sw.js**
 /public/workbox-*.js**
 /public/worker-*.js**
 /public/sw.js.map**
 /public/workbox-*.js.map**
 /public/worker-*.js.map
to the gitignore

Okk I complete the changes and update it

SubhamB2003 · 2023-08-09T19:07:06Z

@priyankarpal Done

priyankarpal · 2023-08-09T19:22:43Z

.gitignore

+**/public/sw.js
+**/public/workbox-*.js
+**/public/worker-*.js
+**/public/sw.js.map
+**/public/workbox-*.js.map
+**/public/worker-*.js.map


I forgot to mention to add these files & also, delete these files these are important

sw.js sw.js.map workbox-3576cac3.js workbox-3576cac3.js.map

Suggested change

**/public/sw.js

**/public/workbox-*.js

**/public/worker-*.js

**/public/sw.js.map

**/public/workbox-*.js.map

**/public/worker-*.js.map

sw.js

sw.js.map

workbox-3576cac3.js

workbox-3576cac3.js.map

@SubhamB2003 please check this

public/manifest.json

SubhamB2003 · 2023-08-10T02:33:21Z

@priyankarpal Done.

priyankarpal · 2023-08-10T04:16:57Z

.gitignore

+**/public/sw.js
+**/public/workbox-*.js
+**/public/worker-*.js
+**/public/sw.js.map
+**/public/workbox-*.js.map
+**/public/worker-*.js.map


@SubhamB2003 please check this

SubhamB2003 · 2023-08-10T05:01:57Z

@priyankarpal can I also removed this?

priyankarpal · 2023-08-10T05:06:39Z

@priyankarpal can I also removed this?

yeah

SubhamB2003 · 2023-08-10T09:11:44Z

@priyankarpal Done.

priyankarpal · 2023-08-10T09:34:34Z

@SubhamB2003 in future please try to create separate branch then create PR. Avoid to create PR from main branch

SubhamB2003 · 2023-08-10T09:37:09Z

@SubhamB2003 in future please try to create separate branch then create PR. Avoid to create PR from main branch

Ok.
Thank you happy to contribute.

SubhamB2003 and others added 3 commits August 9, 2023 23:40

Added PWA

c465c5b

Merge branch 'priyankarpal:main' into main

b601303

Added PWA

469b2a8

github-actions bot added the title-needs-formatting label Aug 9, 2023

github-actions bot reviewed Aug 9, 2023

View reviewed changes

github-actions bot assigned SubhamB2003 Aug 9, 2023

github-actions bot added the wait for reviewers wait for the maintainer label Aug 9, 2023

vercel bot had a problem deploying to Preview August 9, 2023 18:13 Failure

SubhamB2003 changed the title ~~Add PWA to ProjectsHut~~ feat: add pwa to projectshut Aug 9, 2023

github-actions bot removed the title-needs-formatting label Aug 9, 2023

Merge branch 'main' into main

b7dc322

vercel bot had a problem deploying to Preview August 9, 2023 18:23 Failure

priyankarpal requested changes Aug 9, 2023

View reviewed changes

priyankarpal added the changes-required changes-required label Aug 9, 2023

SubhamB2003 added 4 commits August 10, 2023 00:32

fix: changes done

0e4851b

Merge branch 'main' of https://github.com/SubhamB2003/ProjectsHut

539bb25

fix: changes done

3268d18

fix: changes done

a797049

vercel bot deployed to Preview August 9, 2023 19:08 View deployment

priyankarpal requested changes Aug 9, 2023

View reviewed changes

public/manifest.json Outdated Show resolved Hide resolved

Merge branch 'main' into main

a1f2c02

vercel bot deployed to Preview August 9, 2023 19:31 View deployment

Merge branch 'main' into main

c0aeaa1

vercel bot deployed to Preview August 9, 2023 19:57 View deployment

SubhamB2003 added 2 commits August 10, 2023 08:01

fix: changes done

473332d

Merge branch 'main' of https://github.com/SubhamB2003/ProjectsHut

f520426

vercel bot deployed to Preview August 10, 2023 02:33 View deployment

priyankarpal added gssoc23 only for Girlscript summer of code level3 high level fix for GSSoC and removed changes-required changes-required labels Aug 10, 2023

priyankarpal requested changes Aug 10, 2023

View reviewed changes

Merge branch 'main' into main

47ced31

priyankarpal linked an issue Aug 10, 2023 that may be closed by this pull request

feat: Add PWA (Progressive web app) in ProjectsHut #2028

Closed

5 tasks

vercel bot deployed to Preview August 10, 2023 06:35 View deployment

fix: changes done

c0993bc

vercel bot deployed to Preview August 10, 2023 09:12 View deployment

priyankarpal approved these changes Aug 10, 2023

View reviewed changes

priyankarpal merged commit 237c0f5 into priyankarpal:main Aug 10, 2023
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add pwa to projectshut #2044

feat: add pwa to projectshut #2044

SubhamB2003 commented Aug 9, 2023 •

edited

Loading

vercel bot commented Aug 9, 2023 •

edited

Loading

github-actions bot left a comment

priyankarpal commented Aug 9, 2023

priyankarpal left a comment

SubhamB2003 commented Aug 9, 2023

priyankarpal commented Aug 9, 2023 •

edited

Loading

SubhamB2003 commented Aug 9, 2023

SubhamB2003 commented Aug 9, 2023

priyankarpal Aug 9, 2023 •

edited

Loading

priyankarpal Aug 10, 2023

SubhamB2003 commented Aug 10, 2023

priyankarpal Aug 10, 2023

SubhamB2003 commented Aug 10, 2023

priyankarpal commented Aug 10, 2023

SubhamB2003 commented Aug 10, 2023

priyankarpal commented Aug 10, 2023

SubhamB2003 commented Aug 10, 2023

feat: add pwa to projectshut #2044

feat: add pwa to projectshut #2044

Conversation

SubhamB2003 commented Aug 9, 2023 • edited Loading

Related Issue

Description

Screenshots

vercel bot commented Aug 9, 2023 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

priyankarpal commented Aug 9, 2023

priyankarpal left a comment

Choose a reason for hiding this comment

SubhamB2003 commented Aug 9, 2023

priyankarpal commented Aug 9, 2023 • edited Loading

SubhamB2003 commented Aug 9, 2023

SubhamB2003 commented Aug 9, 2023

priyankarpal Aug 9, 2023 • edited Loading

Choose a reason for hiding this comment

priyankarpal Aug 10, 2023

Choose a reason for hiding this comment

SubhamB2003 commented Aug 10, 2023

priyankarpal Aug 10, 2023

Choose a reason for hiding this comment

SubhamB2003 commented Aug 10, 2023

priyankarpal commented Aug 10, 2023

SubhamB2003 commented Aug 10, 2023

priyankarpal commented Aug 10, 2023

SubhamB2003 commented Aug 10, 2023

SubhamB2003 commented Aug 9, 2023 •

edited

Loading

vercel bot commented Aug 9, 2023 •

edited

Loading

priyankarpal commented Aug 9, 2023 •

edited

Loading

priyankarpal Aug 9, 2023 •

edited

Loading