Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: streamlining Social Media Link Collection with GitHub API #2026

Merged
merged 6 commits into from
Aug 9, 2023
Merged

feat: streamlining Social Media Link Collection with GitHub API #2026

merged 6 commits into from
Aug 9, 2023

Conversation

s2sharpit
Copy link
Contributor

Related Issue

Closes: #2018

Description

Streamlining Social Media Link Collection with GitHub API and removing social media link from projects db

Screenshots

@vercel
Copy link

vercel bot commented Aug 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Aug 9, 2023 5:25pm

@github-actions github-actions bot added projects addition add your projects wait for reviewers wait for the maintainer labels Aug 9, 2023
github-actions[bot]
github-actions bot reviewed Aug 9, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @s2sharpit! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@s2sharpit s2sharpit changed the title feat: Streamlining Social Media Link Collection with GitHub API feat: streamlining Social Media Link Collection with GitHub API Aug 9, 2023
@s2sharpit s2sharpit mentioned this pull request Aug 9, 2023
Closed
5 tasks
@s2sharpit s2sharpit changed the title feat: streamlining Social Media Link Collection with GitHub API feat: streamlining social media link collection with github api Aug 9, 2023
@priyankarpal priyankarpal changed the title feat: streamlining social media link collection with github api feat: streamlining Social Media Link Collection with GitHub API Aug 9, 2023
@priyankarpal
Copy link
Owner

let me check

@priyankarpal
Copy link
Owner

@s2sharpit we can create an API provider and use it across all components to streamline our API handling.

@priyankarpal priyankarpal removed the projects addition add your projects label Aug 9, 2023
@github-actions github-actions bot added the projects addition add your projects label Aug 9, 2023
@s2sharpit
Copy link
Contributor Author

s2sharpit commented Aug 9, 2023 •
edited
Loading

@s2sharpit we can create an API provider and use it across all components to streamline our API handling.

@priyankarpal, I didn't understand your point. Are you suggesting creating a separate file named "API provider" or creating a custom API?

@priyankarpal
Copy link
Owner

@s2sharpit we can create an API provider and use it across all components to streamline our API handling.

@priyankarpal, I didn't understand your point. Are you suggesting creating a separate file named "API provider" or creating a custom API?

Yep, I'm saying we should split the API stuff. Just make a new folder or file and put the API code in there.

@s2sharpit
Copy link
Contributor Author

@s2sharpit we can create an API provider and use it across all components to streamline our API handling.

@priyankarpal, I didn't understand your point. Are you suggesting creating a separate file named "API provider" or creating a custom API?

Yep, I'm saying we should split the API stuff. Just make a new folder or file and put the API code in there.

Okay Sure

@s2sharpit
Copy link
Contributor Author

s2sharpit commented Aug 9, 2023 •
edited
Loading

Hey @priyankarpal, I have made changes. Kindly review it.

priyankarpal
priyankarpal approved these changes Aug 9, 2023
View reviewed changes
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level3 high level fix for GSSoC and removed projects addition add your projects labels Aug 9, 2023
@priyankarpal priyankarpal merged commit b8bf64c into priyankarpal:main Aug 9, 2023
8 checks passed
@priyankarpal
Copy link
Owner

@s2sharpit we need to change the docs

@s2sharpit s2sharpit deleted the fix-issue-2018 branch August 9, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@priyankarpal priyankarpal priyankarpal approved these changes

Assignees

@s2sharpit s2sharpit

Labels
gssoc23 only for Girlscript summer of code level3 high level fix for GSSoC wait for reviewers wait for the maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Streamlining Social Media Link Collection with GitHub API
2 participants
@s2sharpit @priyankarpal