Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding skeleton effect to user page #2014

Merged
merged 5 commits into from
Aug 8, 2023
Merged

feat: adding skeleton effect to user page #2014

merged 5 commits into from
Aug 8, 2023

Conversation

s2sharpit
Copy link
Contributor

Related Issue

Closes: #2008

Description

Adding skeleton effect according to the user page components.

Screenshots

20230808_131148.mp4

image

@vercel
Copy link

vercel bot commented Aug 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Aug 8, 2023 1:51pm

@github-actions github-actions bot added the wait for reviewers wait for the maintainer label Aug 8, 2023
github-actions[bot]
github-actions bot reviewed Aug 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @s2sharpit! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@s2sharpit
Copy link
Contributor Author

Hey @priyankarpal, Let me know if you want any changes.
Additionally, I want to consolidate the code for loading cards into a single file by incorporating ProjectLoading.tsx within the Loading.tsx file. Something like this:
image

And will use them in this way:
image

Let me know if you like this suggestion.

@priyankarpal
Copy link
Owner

@s2sharpit yeah we need to make a single file for skeleton effect.

@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level3 high level fix for GSSoC changes-required changes-required labels Aug 8, 2023
@s2sharpit
Copy link
Contributor Author

@s2sharpit yeah we need to make a single file for skeleton effect.

Done

@priyankarpal priyankarpal removed the changes-required changes-required label Aug 8, 2023
priyankarpal
priyankarpal approved these changes Aug 8, 2023
View reviewed changes
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal merged commit b73eeba into priyankarpal:main Aug 8, 2023
6 checks passed
@s2sharpit s2sharpit deleted the fix-issue-2008 branch August 8, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@priyankarpal priyankarpal priyankarpal approved these changes

Assignees

@s2sharpit s2sharpit

Labels
gssoc23 only for Girlscript summer of code level3 high level fix for GSSoC wait for reviewers wait for the maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add skeleton effect to user page
2 participants
@s2sharpit @priyankarpal