Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: project addition by nc1z #2000 #1977

Merged
merged 2 commits into from
Aug 7, 2023
Merged

chore: project addition by nc1z #2000 #1977

merged 2 commits into from
Aug 7, 2023

Conversation

nc1z
Copy link
Contributor

@nc1z nc1z commented Aug 6, 2023

Related Issue

Closes issue #2000

Add a new project to the list

Adding an open source React PWA Starter template, built with Create-React-App, MUI and Firebase

Record

@vercel
Copy link

vercel bot commented Aug 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Aug 7, 2023 2:38pm

@github-actions github-actions bot added projects addition add your projects wait for reviewers wait for the maintainer labels Aug 6, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @nc1z! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nc1z please add the issue number

DB/projects.json Outdated Show resolved Hide resolved
@priyankarpal priyankarpal added no issue number contributor haven't added the issue number changes-required changes-required labels Aug 6, 2023
@nc1z nc1z changed the title chore: project addition by nc1z chore: project addition by nc1z #1977 Aug 6, 2023
@nc1z
Copy link
Contributor Author

nc1z commented Aug 6, 2023

@priyankarpal do I create a new issue or I'm good to use the PR ticket number? Thanks

@priyankarpal
Copy link
Owner

@priyankarpal do I create a new issue or I'm good to use the PR ticket number? Thanks

create a new issue for project addition & add the issue number to the PR description. & add reactjs to the tech stacks

DB/projects.json Outdated Show resolved Hide resolved
DB/projects.json Outdated Show resolved Hide resolved
@nc1z nc1z changed the title chore: project addition by nc1z #1977 chore: project addition by nc1z #2000 Aug 7, 2023
@nc1z nc1z requested a review from priyankarpal August 7, 2023 14:13
@priyankarpal
Copy link
Owner

this branch has a conflicts error. Please resolve it

@priyankarpal priyankarpal added conflict this branch has conflicts error and removed no issue number contributor haven't added the issue number labels Aug 7, 2023
@priyankarpal priyankarpal linked an issue Aug 7, 2023 that may be closed by this pull request
4 tasks
@nc1z
Copy link
Contributor Author

nc1z commented Aug 7, 2023

There's quite a bit of formatting errors from previous project additions that have been merged to main. I've just re-added mine instead of editing others. Should be ahead of main now.

DB/projects.json Outdated
{
"github_username": "nc1z",
"Social_media": {
"gitHub": "https://github.com/nc1z",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the line also

Suggested change
"gitHub": "https://github.com/nc1z",

@priyankarpal
Copy link
Owner

There's quite a bit of formatting errors from previous project additions that have been merged to main. I've just re-added mine instead of editing others. Should be ahead of main now.

try to create separate branch in future.

@nc1z
Copy link
Contributor Author

nc1z commented Aug 7, 2023

There's quite a bit of formatting errors from previous project additions that have been merged to main. I've just re-added mine instead of editing others. Should be ahead of main now.

try to create separate branch in future.

Makes sense, apologies relatively new to forking & open source contributing 😄

Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing your projects here 👏🏻 🎉

@priyankarpal
Copy link
Owner

@nc1z For secure collaboration, remember to check out GitHub's commit signature verification feature. It helps ensure the authenticity of commits and prevents tampering.

Learn how it works: GitHub Docs

Happy coding! 😄

@priyankarpal priyankarpal merged commit 690c772 into priyankarpal:main Aug 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-required changes-required conflict this branch has conflicts error projects addition add your projects wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: project addition by nc1z
2 participants