-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: project addition by nc1z #2000 #1977
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @nc1z! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nc1z please add the issue
number
@priyankarpal do I create a new issue or I'm good to use the PR ticket number? Thanks |
create a new issue for project addition & add the issue number to the PR description. & add |
this branch has a conflicts error. Please resolve it |
There's quite a bit of formatting errors from previous project additions that have been merged to main. I've just re-added mine instead of editing others. Should be ahead of main now. |
DB/projects.json
Outdated
{ | ||
"github_username": "nc1z", | ||
"Social_media": { | ||
"gitHub": "https://github.com/nc1z", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the line also
"gitHub": "https://github.com/nc1z", |
try to create separate branch in future. |
Makes sense, apologies relatively new to forking & open source contributing 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing your projects here 👏🏻 🎉
@nc1z For secure collaboration, remember to check out GitHub's commit signature verification feature. It helps ensure the authenticity of commits and prevents tampering. Learn how it works: GitHub Docs Happy coding! 😄 |
Related Issue
Closes issue #2000
Add a new project to the list
Adding an open source React PWA Starter template, built with Create-React-App, MUI and Firebase
Record