feat: implementing dynamic title to pages #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tushar Saini <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @s2sharpit! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
s2sharpit
commented
Jul 31, 2023
priyankarpal
requested changes
Aug 1, 2023
Signed-off-by: Tushar Saini <[email protected]>
…sHut into fix-issue-1875
priyankarpal
requested changes
Aug 1, 2023
|
@priyankarpal, I think the better way to add types is to use types provided by NextJs. What so you say? |
yeah we can |
Signed-off-by: Tushar Saini <[email protected]>
|
I have applied the types provided by Nextjs. Kindly review the PR now. |
priyankarpal
added
gssoc23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes: #1875
Description
Implementing Dynamic Titles for consistency and better SEO
Screenshots