Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated and Modified title, aria-label for Social Links in Some Pages #1888

Merged
merged 1 commit into from
Jul 29, 2023
Merged

fix: Updated and Modified title, aria-label for Social Links in Some Pages #1888

merged 1 commit into from
Jul 29, 2023

Conversation

NarendraKoya999
Copy link
Contributor

Related Issue

Closes Issue No : #1878

Description

  • Added aria-label and title attributes to respective Social Links in app/projects/[username]/page.tsx -File
  • Added title attributes to Respective Social Links a nd Modified aria-label for Social Links to Improve Scalability and Clean Code of Same Content in components/Footer.tsx- File
  • Added title and aria-label attributes to GitHub Social Link in components/ProjectCard.tsx- File

Screenshots

@vercel
Copy link

vercel bot commented Jul 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Jul 29, 2023 3:16pm

@github-actions github-actions bot added the wait for reviewers wait for the maintainer label Jul 29, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @NarendraKoya999! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@NarendraKoya999
Copy link
Contributor Author

Hi @priyankarpal . Please review on this PR

Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC labels Jul 29, 2023
@priyankarpal
Copy link
Owner

Hey @NarendraKoya999 ! 👋

For secure collaboration, remember to check out GitHub's commit signature verification feature. It helps ensure the authenticity of commits and prevents tampering.

Learn how it works: GitHub Docs

Happy coding! 😄

@priyankarpal priyankarpal merged commit f18da21 into priyankarpal:main Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Missing title Attribute for All Social Links Existed in Respective Web Pages
2 participants