Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Animated Landing Page #1866

Merged
merged 7 commits into from
Jul 30, 2023
Merged

Conversation

Souravvmishra
Copy link
Contributor

Related Issue

Description

Resolved #1823

Added animation to the landing page. I found these value good, if you have any issue or want any change in animation, I'll be more than happy to do so.

Screenshots

@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Jul 30, 2023 5:07am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Souravvmishra! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Souravvmishra please use pnpm i to install all packages

@priyankarpal priyankarpal added the changes-required changes-required label Jul 27, 2023
@Souravvmishra Souravvmishra changed the title Animated Landing Page chore:Animated Landing Page Jul 27, 2023
@Souravvmishra
Copy link
Contributor Author

@priyankarpal Can you please, what else needs to be done?

@priyankarpal
Copy link
Owner

@priyankarpal Can you please, what else needs to be done?

will check soon

@priyankarpal priyankarpal changed the title chore:Animated Landing Page chore: Animated Landing Page Jul 27, 2023
@priyankarpal
Copy link
Owner

@priyankarpal Can you please, what else needs to be done?

will check soon

we need to add animations for all pages( docs, projects page, user profile)

@Souravvmishra
Copy link
Contributor Author

yup, adding animations require checking possible values to find the best one that fits all the screen sizes.
I would like to create one PR for each page.
If you allow 😅

@Souravvmishra
Copy link
Contributor Author

Any Update?

@priyankarpal
Copy link
Owner

yup, adding animations require checking possible values to find the best one that fits all the screen sizes. I would like to create one PR for each page. If you allow 😅

Any Update?

I will check soon

Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Souravvmishra use this command pnpm install --no-frozen-lockfile & push

@Souravvmishra
Copy link
Contributor Author

@priyankarpal Please Review Brother

@priyankarpal
Copy link
Owner

@priyankarpal Please Review Brother

yeah sure

@priyankarpal priyankarpal removed the changes-required changes-required label Jul 30, 2023
@priyankarpal priyankarpal changed the title chore: Animated Landing Page style: Animated Landing Page Jul 30, 2023
@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level3 high level fix for GSSoC labels Jul 30, 2023
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal merged commit dfaeb19 into priyankarpal:main Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 only for Girlscript summer of code level3 high level fix for GSSoC wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Adding Animations to the website
2 participants