Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added 404 page #1663

Merged
merged 5 commits into from
Jul 12, 2023
Merged

feat: added 404 page #1663

merged 5 commits into from
Jul 12, 2023

Conversation

PriyansuMaurya
Copy link
Contributor

Related Issue

#1645

Description

Screenshots

Desktop:

image

@vercel
Copy link

vercel bot commented Jul 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Jul 12, 2023 2:43pm

github-actions[bot]
github-actions bot reviewed Jul 10, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @PriyansuMaurya! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@github-actions github-actions bot added the wait for reviewers wait for the maintainer label Jul 10, 2023
@priyankarpal priyankarpal linked an issue Jul 11, 2023 that may be closed by this pull request
feat: Not Found Page #1645
Closed
3 tasks
priyankarpal
priyankarpal requested changes Jul 11, 2023
View reviewed changes
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PriyansuMaurya change the PR title to feat: added 404 page

@priyankarpal priyankarpal added the changes-required changes-required label Jul 11, 2023
priyankarpal
priyankarpal requested changes Jul 11, 2023
View reviewed changes
app/not-found.tsx Outdated Show resolved Hide resolved
app/not-found.tsx Outdated Show resolved Hide resolved
app/not-found.tsx Outdated Show resolved Hide resolved
app/not-found.tsx Outdated Show resolved Hide resolved
app/not-found.tsx Outdated Show resolved Hide resolved
priyankarpal
priyankarpal requested changes Jul 11, 2023
View reviewed changes
app/not-found.tsx Outdated Show resolved Hide resolved
@PriyansuMaurya PriyansuMaurya changed the title Added : Not Found Page feat: added 404 page Jul 12, 2023
@PriyansuMaurya
Copy link
Contributor Author

you don't want header and footer in "not-found" page?

@priyankarpal
Copy link
Owner

you don't want header and footer in "not-found" page?

I have added <Footer/> comp to layout.tsx previously just we need to add <Navbar/> comp to layout.tsx

priyankarpal
priyankarpal approved these changes Jul 12, 2023
View reviewed changes
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉 👏🏻

@priyankarpal priyankarpal merged commit 1241f12 into priyankarpal:main Jul 12, 2023
@PriyansuMaurya
Copy link
Contributor Author

I have added <Footer/> comp to layout.tsx previously just we need to add <Navbar/> comp to layout.tsx

Great, Got you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@priyankarpal priyankarpal priyankarpal approved these changes

Assignees

@PriyansuMaurya PriyansuMaurya

Labels
changes-required changes-required wait for reviewers wait for the maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Not Found Page
2 participants
@PriyansuMaurya @priyankarpal