-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Improved Docs Page Codebase #1579
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @adity2911! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
I think currently we don't need to change anything. you're working on new feature |
okay. well i thought you gave this issue a go after what you said at our discussion on issue #1517 |
Signed-off-by: Aditya Tulsiyan <[email protected]>
well this is a part of the changes supposed to be made for issue #1519 |
yeah I know but we will change the docs page UI & code then we need to change just work on that issue |
Kindly accept this as a level1 or 2 issue only. I have worked twice on the same issue. |
Plus I was assigned this issue by you only. |
Signed-off-by: Aditya Tulsiyan <[email protected]>
Okay. Noted. |
will merge soon |
Related Issue
#1517
Description
I have made the code easier to read and modular, based on the concept of DRY. This code is renders the exact same webpage as before, while also making it readable.
Lines of code halved from 427 to 261.
Screenshots