-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: map to render nav links for mobile navbar #1553
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @adity2911! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
Signed-off-by: Aditya Tulsiyan <[email protected]>
in future please avoid creating PR first. @adity2911 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the PR title to fix: map to render nav links for mobile navbar
Signed-off-by: Aditya Tulsiyan <[email protected]>
@priyankarpal The requests have been completed. Kindly let me know if you want anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good 🎉
Related Issue #1554
Description
Instead of writing individual links to render at the navbar, only updating the linksComponent will do so now.