Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map to render nav links for mobile navbar #1553

Merged
merged 6 commits into from
Jul 4, 2023
Merged

fix: map to render nav links for mobile navbar #1553

merged 6 commits into from
Jul 4, 2023

Conversation

adity2911
Copy link
Contributor

@adity2911 adity2911 commented Jul 4, 2023

Related Issue #1554

Description

Instead of writing individual links to render at the navbar, only updating the linksComponent will do so now.

@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Jul 4, 2023 1:37pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @adity2911! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Signed-off-by: Aditya Tulsiyan <[email protected]>
@priyankarpal
Copy link
Owner

in future please avoid creating PR first. @adity2911

components/SideMenu.tsx Outdated Show resolved Hide resolved
components/SideMenu.tsx Outdated Show resolved Hide resolved
@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC labels Jul 4, 2023
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the PR title to fix: map to render nav links for mobile navbar

@priyankarpal priyankarpal added the changes-required changes-required label Jul 4, 2023
@adity2911 adity2911 changed the title Used map to render components into the navbar fix: map to render nav links for mobile navbar Jul 4, 2023
Signed-off-by: Aditya Tulsiyan <[email protected]>
@adity2911
Copy link
Contributor Author

@priyankarpal The requests have been completed. Kindly let me know if you want anything else.

Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal merged commit 4f43a51 into priyankarpal:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-required changes-required gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of linksList to render components into the navbar
2 participants