Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed project input background and updated yarn.lock file #1028 #1189

Merged

Conversation

jibola2588
Copy link
Contributor

Related Issue

The input background was changed from white to transparent and a focus effect was added to the input element #1028

Description

Add focus to project input, remove the background color

Ensure focus functionality on input, and improve the visual appearance

Updated yarn.lock file

Screenshots

@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Jun 13, 2023 4:24pm

@github-actions github-actions bot added the wait for reviewers wait for the maintainer label Jun 12, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @jibola2588! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text is not visible add text color white for dark mode & black for white mode

image

src/pages/ProjectsPage.jsx Outdated Show resolved Hide resolved
@priyankarpal priyankarpal added the changes-required changes-required label Jun 13, 2023
@jibola2588
Copy link
Contributor Author

sir, I have made the changes you requested and updated the branch, I am in GSSOC'23.

@priyankarpal priyankarpal added the gssoc23 only for Girlscript summer of code label Jun 13, 2023
@priyankarpal priyankarpal added the level1 small level fix for GSSoC label Jun 13, 2023
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal removed the changes-required changes-required label Jun 13, 2023
@priyankarpal priyankarpal merged commit 653d75c into priyankarpal:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants