-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hero section image grid #1092
fix: hero section image grid #1092
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Sanchitbajaj02! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…into fix-issue-1032
nope but mobile view
Mobile viewDesktop view |
Have you reverted the changes? @Sanchitbajaj02 |
…to fix-issue-1032
I reverted the max-width problem that was occurring. I fix the card grid for 350 screen size and above |
Related Issue
As mentioned in issue #1032, the home page image grid is not looking good on mobile screens. The issue I detected is related to the max-width issue and excessive use of absolute properties.
Description
To solve this issue, I first tried to remove all the dependencies related to absolute classes and use a grid to make 2 columns and align the content in them but to remove the existing code and rewrite it for all different screen sizes was kind of a hassle and disrespect to all the contributors who worked hard to create that section.
So, to fix that, I optimize the existing absolute classes for different screen sizes and gave a global max width class to set the content's max width.
Screenshots
Before
After