Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simple close button for the filter panel #1876

Closed
4 of 5 tasks
pewpewnor opened this issue Jul 28, 2023 · 3 comments
Closed
4 of 5 tasks

feat: Simple close button for the filter panel #1876

pewpewnor opened this issue Jul 28, 2023 · 3 comments
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software ⭐ goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for dev Ready for work

Comments

@pewpewnor
Copy link
Contributor

What feature?

In the /projects directory, there is a filter button that opens up a dialog panel/pop-up to allow the user to select the desired filter. However, some users may be confused about how to close the filter panel because, currently, the only way to do so is by clicking anywhere outside of the filter panel. In my own experience, I was confused about how to close it since I intuitively looked for a close button.

Benefits:

  • Reduce confusion regarding how to close the filter panel.
  • Increase intuitiveness in the process of selecting filters.

Solution:
We can a simple close button on the top right of the filter panel.

Add screenshots

Demo screenshot of the new close button:

  • View for desktop users:
    image

  • View for mobile users:
    image

Record

@pewpewnor pewpewnor added ⭐ goal: addition Addition of new feature 🚦status: awaiting triage Has not been triaged & therefore, not ready for work labels Jul 28, 2023
@github-actions
Copy link

To reduce notifications, issues are locked. Your issue will be unlock when we will add label as 🏁 status: ready for dev. Check out the contributing guide for more information. Also, if you're in GSSoC'23 please check the discussion

@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
Repository owner unlocked this conversation Jul 29, 2023
@priyankarpal priyankarpal added 🏁 status: ready for dev Ready for work 🟨 priority: medium Not blocking but should be fixed soon 💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software and removed 🚦status: awaiting triage Has not been triaged & therefore, not ready for work labels Jul 29, 2023
@priyankarpal
Copy link
Owner

priyankarpal commented Jul 29, 2023

yeah we need to add. just remove the text close & use only icon. Assigned to you

@pewpewnor
Copy link
Contributor Author

Will do @priyankarpal, I have made the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software ⭐ goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for dev Ready for work
Projects
None yet
Development

No branches or pull requests

2 participants