fix: send SIGKILL on unresponsive process #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/cli.ts
Outdated
| * a SIGKILL if the childProcess.on('close') handler | ||
| * defined below is not called within 10ms. | ||
| */ | ||
| setTimeout(() => childProcess.kill('SIGKILL'), 10); |
There was a problem hiding this comment.
This will break cases where the child handles the SIGINT signal, either by refusing to close or running a slow handler:
process.on('SIGINT', () => {
// slow code
});
privatenumber
changed the title
|
🎉 This issue has been resolved in v4.4.0 If you appreciate this project, please consider supporting this project by sponsoring ❤️ 🙏 |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394
This fix checks if the child is responsive before sending a SIGKILL. If it is, we assume the child doesn't want to exit by ignoring the SIGINT.