Add handling of private aggregation paggResponse field in response #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingxinwu
requested review from
dankocoj-google and
brusshamilton
as code owners
qingxinwu
changed the title
|
@brusshamilton PTAL, thanks! |
filteringId was supported since M128 on Chrome, and B&A are just focusing on features available before M120 at this moment.
| an optional `desired total size`, an optional list of `interest group owners` to | ||
| include each with an optional `desired size`, and the [HPKE] `public key` and |
There was a problem hiding this comment.
The extra "and" was intentional here, as a way of grouping the key with its key ID. We could change the second "and" to "with" if you think that would be more clear.
| This algorithm takes as input all of the `relevant interest groups`, and a config | ||
| consisting of the `publisher`, | ||
| This algorithm takes as input all of the `relevant interest groups`, a config | ||
| consisting of the `publisher`, a map of from (origin, string) tuple to origin |
There was a problem hiding this comment.
I would have thought we could calculate ig pagg coordinators from the relevant interest groups. I think we'd rather do that than have it as a separate argument.
| @@ -471,7 +472,8 @@ tuple. | |||
| larger than request. | |||
| 1. Encrypt `request` using the `public key` and its `key id` as in | |||
| {{request-encryption}} to get the `encrypted message` and `hpke context`. | |||
| 1. Let the `request context` be the tuple (`included_groups`, `hpke context`) | |||
| 1. Let the `request context` be the tuple | |||
| (`included_groups`, `hpke context`, `ig pagg coordinators`). | |||
There was a problem hiding this comment.
Would it make more sense to expand included_groups to be a list of (name, pagg coordinator) pairs? That would avoid the extra redundancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.