Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Consider removing implementation-defined steps because we have requesting permission to use #156

Closed
johannhof opened this issue Jan 12, 2023 · 1 comment · Fixed by #161
Closed

Editorial: Consider removing implementation-defined steps because we have requesting permission to use #156

johannhof opened this issue Jan 12, 2023 · 1 comment · Fixed by #161
Assignees
@johannhof
Labels
editorial This is not a normative change

Comments

@johannhof
Copy link
Member

Requesting permission to use should allow UAs to make implementation-defined decisions around whether or not prompts are shown. We could consider removing the implementation defined steps in determining the storage access policy and just adding some more clarification in the Permissions API.

This might make it harder to understand that there are implementation defined steps involved, so I'm not sure we should do it.

cc @annevk
@johannhof johannhof added the editorial This is not a normative change label Jan 12, 2023
@bvandersloot-mozilla
Copy link
Collaborator

I think it is fine, so long as we throw a Note in that makes it clear that the Permissions API contains implementation variation.

@johannhof johannhof self-assigned this Jan 23, 2023
johannhof added a commit to johannhof/storage-access that referenced this issue Jan 23, 2023
@johannhof
Switch to (top-level site, embedded site) keying (closes privacycg#147,
578483d 
privacycg#156)

This updates the permission key for storage-access to (site, site), and
also removes the concept of the "partitioned storage key", which was
origin-keyed as well. The storage key was only used for running the
implementation-defined steps that are supposed to be removed as of privacycg#156.
@johannhof johannhof mentioned this issue Jan 23, 2023
Merged
3 tasks
johannhof added a commit to johannhof/storage-access that referenced this issue Jan 26, 2023
@johannhof
Remove partitioned storage key and implementation-defined steps
a86a871 
(closes privacycg#156)

This was originally part of privacycg#159 but I'm submitting it separately since
this is a rather editorial change that we can probably fast-track
without including it in the other PR which still needs WPT etc.
@johannhof johannhof mentioned this issue Jan 26, 2023
Merged
johannhof added a commit that referenced this issue Jan 27, 2023
@johannhof
Remove partitioned storage key and implementation-defined steps (#161)
17ff4fd 
(closes #156)

This was originally part of #159 but I'm submitting it separately since
this is a rather editorial change that we can probably fast-track
without including it in the other PR which still needs WPT etc.
johannhof added a commit that referenced this issue Mar 29, 2023
@johannhof
Switch to (top-level site, embedded site) keying (#159)
ceca554 
(closes #147, #156)

This updates the permission key for storage-access to (site, site), and
also removes the concept of the "partitioned storage key", which was
origin-keyed as well. The storage key was only used for running the
implementation-defined steps that are supposed to be removed as of #156.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johannhof johannhof

Labels
editorial This is not a normative change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: Remove partitioned storage key and implementation-defined steps johannhof/storage-access
2 participants
@johannhof @bvandersloot-mozilla