Fix local bikeshed build errors #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaliev
reviewed
Feb 20, 2025
README.md
Outdated
| @@ -1,5 +1,13 @@ | |||
| # Navigation-based Tracking Mitigations | |||
|
|
|||
| <!-- START doctoc generated TOC please keep comment here to allow auto update --> | |||
| <!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE --> | |||
| ## Table of Contents | |||
There was a problem hiding this comment.
Can we exempt this file from doctoc? the TOC doesn't add much here.
There was a problem hiding this comment.
doctoc only manages the readme file. It otherwise does nothing in this repo. I reverted the readme back to its original state and removed the doctoc-related target instead.
amaliev
approved these changes
Feb 20, 2025
|
@jyasskin do you mind taking a look at this pull request? I believe you're a maintainer of this repo. |
jyasskin
approved these changes
Feb 24, 2025
github-actions bot
added a commit
that referenced
this pull request
Feb 24, 2025
SHA: 579316d Reason: push, by jyasskin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The makefile targets don't work due to minor errors. This PR fixes those errors such that building the spec locally works from the makefile. These are the specific changes:
README.mdsodoctocwill not modify the file at HEAD.builddirectory. (The diagram in the spec won't render properly otherwise. Also outputtingindex.htmlin the root is consistent with that the GitHub action does.)bikesheddoes not support taking in images, so it will always have a warning.In the future, I propose removing
doctocand the remote build target altogether. The table of contents is somewhat nonexistent, sodoctocis an unnecessary dependency. The remote build already has degraded service, so using a local version ofbikeshedmake more sense. (However, for this PR, I'd prefer to only fix what's broken.)