Implement /getPs endpoint for new keyshare protocol #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 14, 2022 16:52
…_0^secret) prior to issuance. This is needed for the client to calculate the hash h_w.
synaptic-cleft
changed the title
ivard
previously approved these changes
Nov 25, 2022
There was a problem hiding this comment.
Looks good. The only thing I noticed was that c.verifyAccess is called twice, once in the middleware and once in the request handler. But this is also the case in all the other endpoints, so this is not really an issue of this PR. Since it concerns sensitive information, this might have been intentional. A comment might have helped in that case.
bobhageman
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.