Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond with a 204 HTTP status code after cancelling a Session #142

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Respond with a 204 HTTP status code after cancelling a Session #142

wants to merge 3 commits into from

Commits on Mar 17, 2021

  1. Respond with a 204 HTTP status code after cancelling a Session

    According to the official HTTP/1.1 specs a successful DELETE request
    can be handled in various ways.
    
    > If a DELETE method is successfully applied, the origin server SHOULD send a 202 (Accepted) status code if the action will likely succeed but has not yet been enacted, a 204 (No Content) status code if the action has been enacted and no further information is to be supplied, or a 200 (OK) status code if the action has been enacted and the response message includes a representation describing the status.
    
    This commit will make sure a 204 HTTP status code is returned
    after successfully cancelling the session.
    Stefan Vermaas committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    f205586 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Use the http.StatusNoContent instead of hardcoding the 204 HTTP respo…

    …nse code.
    Stefan Vermaas committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    35ac125 View commit details
    Browse the repository at this point in the history
  2. Test setup for verifying the HTTP response headers for cancelling an …

    …IRMA session.
    Stefan Vermaas committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    eaad910 View commit details
    Browse the repository at this point in the history