Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added Merkle tree use recommendations #315

Conversation

0xarcano
Copy link
Contributor

@0xarcano 0xarcano commented Aug 29, 2024

Description

Added FAQ to guide the developers about when and why use a specific type of Merkle tree for their projects

The FAQ has a short text answer plus a comparison table with more detailed data Refs: #311

Related Issue(s)

docs: add section to help choose merkle tree #311

Checklist

It would be helpful to write a comparison of of all them, answering questions like

  • "when not to use"/"when to use"
  • "used by?": protocol xyz, app xyz...
  • include benchmarks: maybe one merkle tree is faster at generating a proof, but slower to update?

Added FAQ to guide the developers about when and why use a specific type of Merkle tree for their projects

The FAQ has a short text answer plus a comparison table with more detailed data
Refs: privacy-scaling-explorations#311
Copy link
Member

@sripwoud sripwoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the table!
Just a small request for change regarding the formatting.
And make sure to check the formatting to ensure the CI check passes (see code quality and formatting)

What about benchmarks? Would you like tackling that in a later PR too?
Collecting data like this would be amazing (we could easily build nice charts from it):

Tree Type size (MB and/or leaves and/or tree depth ) operation (insert, update ...) time (ms)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@0xarcano
Copy link
Contributor Author

Sure, I can send it in another PR if you think it is a good idea

Fix README format (prettier)

Fix missing new lines in explanation text

Add links to the homepage of the projects

re 315
Fix README format (prettier)

Fix missing new lines in explanation text

Add links to the homepage of the projects

re 315
@0xarcano
Copy link
Contributor Author

I have already made the changes of formatting and the home pages URL for the projects, please help me with the review

Copy link
Member

@sripwoud sripwoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK
@cedoor this looks good to merge to me.

@cedoor cedoor merged commit 253277c into privacy-scaling-explorations:main Sep 2, 2024
2 checks passed
Copy link

gitpoap-bot bot commented Sep 2, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 ZK-KIT Contributor:

GitPOAP: 2024 ZK-KIT Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@0xarcano
Copy link
Contributor Author

0xarcano commented Sep 2, 2024

Thank you very much, I'm happy to start contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants