-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added Merkle tree use recommendations #315
docs: added Merkle tree use recommendations #315
Conversation
Added FAQ to guide the developers about when and why use a specific type of Merkle tree for their projects The FAQ has a short text answer plus a comparison table with more detailed data Refs: privacy-scaling-explorations#311
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the table!
Just a small request for change regarding the formatting.
And make sure to check the formatting to ensure the CI check passes (see code quality and formatting)
What about benchmarks? Would you like tackling that in a later PR too?
Collecting data like this would be amazing (we could easily build nice charts from it):
Tree Type | size (MB and/or leaves and/or tree depth ) | operation (insert, update ...) | time (ms) |
---|
Sure, I can send it in another PR if you think it is a good idea |
Fix README format (prettier) Fix missing new lines in explanation text Add links to the homepage of the projects re 315
Fix README format (prettier) Fix missing new lines in explanation text Add links to the homepage of the projects re 315
I have already made the changes of formatting and the home pages URL for the projects, please help me with the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
@cedoor this looks good to merge to me.
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 ZK-KIT Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Thank you very much, I'm happy to start contributing! |
Description
Added FAQ to guide the developers about when and why use a specific type of Merkle tree for their projects
The FAQ has a short text answer plus a comparison table with more detailed data Refs: #311
Related Issue(s)
docs: add section to help choose merkle tree #311
Checklist
It would be helpful to write a comparison of of all them, answering questions like