Skip to content
This repository has been archived by the owner on Nov 23, 2023. It is now read-only.

Merge client & server #195

Merged
merged 12 commits into from
Apr 19, 2023
Merged

Merge client & server #195

merged 12 commits into from
Apr 19, 2023

Conversation

brech1
Copy link
Member

@brech1 brech1 commented Apr 13, 2023

Description

This PR simplifies the project structure and establishes a new way of interacting with the protocol.

  • Solves #186

Changes

  • The server crate has been removed. The project no longer has a HTTP server implementation.
  • The attestation proof generation functionality has now been moved to the client directory.
  • There is a new client CLI command: generate-proof. This will fetch every attestation from the contract, generate a proof and store it into a file.
  • The verify command has now been updated to load the proof from the file instead of fetching it from the server.
  • The README has been updated to describe this new functionality.
  • It also include some minor fixes.

client/README.md Outdated Show resolved Hide resolved
client/src/main.rs Outdated Show resolved Hide resolved
client/src/manager.rs Outdated Show resolved Hide resolved
@lazovicff
Copy link
Collaborator

lazovicff commented Apr 16, 2023

Whats the reasoning behind attestation.rs inside manager folder. The Attestation is used both in Manager and the EigenTrustClient?

Btw, we could rename EigenTrustClient to Client.

client/src/utils.rs Outdated Show resolved Hide resolved
@brech1
Copy link
Member Author

brech1 commented Apr 17, 2023

Whats the reasoning behind attestation.rs inside manager folder. The Attestation is used both in Manager and the EigenTrustClient?

Btw, we could rename EigenTrustClient to Client.

It was inherited from the server structure, but it makes sense for attestation to be it's own module. I'll submit a fix for this, including the renaming of EigenTrustClient.

@brech1 brech1 force-pushed the refactor/client-server-merge branch from c7ea2e6 to f451aac Compare April 19, 2023 00:23
@brech1 brech1 force-pushed the refactor/client-server-merge branch from dc44c45 to 1e7cdeb Compare April 19, 2023 00:50
@brech1 brech1 marked this pull request as ready for review April 19, 2023 00:51
lazovicff
lazovicff previously approved these changes Apr 19, 2023
@lazovicff lazovicff merged commit aa054e7 into master Apr 19, 2023
@brech1 brech1 deleted the refactor/client-server-merge branch April 19, 2023 21:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants