This repository has been archived by the owner on Nov 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazovicff
reviewed
Apr 16, 2023
lazovicff
reviewed
Apr 16, 2023
lazovicff
reviewed
Apr 16, 2023
Whats the reasoning behind Btw, we could rename |
lazovicff
reviewed
Apr 16, 2023
It was inherited from the server structure, but it makes sense for |
brech1
force-pushed
the
refactor/client-server-merge
branch
from
April 19, 2023 00:23
c7ea2e6
to
f451aac
Compare
brech1
force-pushed
the
refactor/client-server-merge
branch
from
April 19, 2023 00:50
dc44c45
to
1e7cdeb
Compare
lazovicff
previously approved these changes
Apr 19, 2023
lazovicff
approved these changes
Apr 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the project structure and establishes a new way of interacting with the protocol.
Changes
server
crate has been removed. The project no longer has a HTTP server implementation.client
directory.generate-proof
. This will fetch every attestation from the contract, generate a proof and store it into a file.verify
command has now been updated to load the proof from the file instead of fetching it from the server.