Merge pull request #36 from privacy-scaling-explorations/feat/public_…

…data

Feat/public data

packages/actions/src/helpers/constants.ts

@@ -133,6 +133,7 @@ export const commonTerms = {
         verifyContribution: "verifycontribution",
         checkAndPrepareCoordinatorForFinalization: "checkAndPrepareCoordinatorForFinalization",
         finalizeCircuit: "finalizeCircuit",
-        finalizeCeremony: "finalizeCeremony"
+        finalizeCeremony: "finalizeCeremony",
+        downloadCircuitArtifacts: "downloadCircuitArtifacts"
     }
 }

packages/actions/src/helpers/functions.ts

@@ -448,4 +448,4 @@ export const finalizeCeremony = async (functions: Functions, ceremonyId: string)
     await cf({
         ceremonyId
     })
-}
+}

packages/actions/src/types/index.ts

@@ -533,4 +533,4 @@ export type CeremonyArtifacts = {
 export type ContributionDocumentReferenceAndData = {
     uid: string
     data: ContributionDocument
-}
+}

packages/actions/test/unit/contribute.test.ts

@@ -91,11 +91,9 @@ describe("Contribute", () => {
         })
         /// @note running on emulator gives a different error
         if (envType === TestingEnvironment.PRODUCTION) {
-            it("should fail when not authenticated", async () => {
+            it("should succeed when not authenticated", async () => {
                 await signOut(userAuth)
-                await expect(getOpenedCeremonies(userFirestore)).to.be.rejectedWith(
-                    "Missing or insufficient permissions."
-                )
+                await expect(getOpenedCeremonies(userFirestore)).to.be.fulfilled
             })
         }
         it("should allow to retrieve all opened ceremonies", async () => {
@@ -133,14 +131,6 @@ describe("Contribute", () => {
                 fakeCircuitsData.fakeCircuitSmallNoContributors
             )
         })
-        if (envType === TestingEnvironment.PRODUCTION) {
-            it("should fail when not authenticated", async () => {
-                await signOut(userAuth)
-                await expect(
-                    getCeremonyCircuits(userFirestore, fakeCeremoniesData.fakeCeremonyOpenedFixed.uid)
-                ).to.be.rejectedWith("Missing or insufficient permissions.")
-            })
-        }
         it("should return the circuits for the specified ceremony", async () => {
             // auth
             await signInWithEmailAndPassword(userAuth, users[0].data.email, passwords[0])

packages/actions/test/unit/database.test.ts

@@ -93,14 +93,6 @@ describe("Database", () => {
             ])
             expect(query.docs.length).to.be.gt(0)
         })
-        it("should revert when not logged in", async () => {
-            await signOut(userAuth)
-            await expect(
-                queryCollection(userFirestore, commonTerms.collections.ceremonies.name, [
-                    where(commonTerms.collections.ceremonies.fields.state, "==", CeremonyState.OPENED)
-                ])
-            ).to.be.rejected
-        })
     })
 
     describe("getAllCollectionDocs", () => {
@@ -120,10 +112,6 @@ describe("Database", () => {
             const collection = await getAllCollectionDocs(userFirestore, commonTerms.collections.ceremonies.name)
             expect(collection.length).to.be.gt(0)
         })
-        it("should revert when not logged in", async () => {
-            await signOut(userAuth)
-            await expect(getAllCollectionDocs(userFirestore, commonTerms.collections.ceremonies.name)).to.be.rejected
-        })
     })
 
     describe("fromQueryToFirebaseDocumentInfo", () => {
@@ -152,7 +140,7 @@ describe("Database", () => {
             await expect(getDocumentById(userFirestore, commonTerms.collections.users.name, users[0].uid)).to.be
                 .rejected
         })
-        it("should an authenticated user to get a ceremonies document", async () => {
+        it("should an authenticated user to get a ceremony document", async () => {
             await signInWithEmailAndPassword(userAuth, users[0].data.email, passwords[0])
             const userDoc = await getDocumentById(
                 userFirestore,

packages/actions/test/unit/security.test.ts

@@ -262,13 +262,13 @@ describe("Security", () => {
                     getDocumentById(userFirestore, commonTerms.collections.users.name, users[0].uid)
                 ).to.be.rejectedWith("Missing or insufficient permissions.")
             })
-            /// @note unauthenticated users should not be able to access any data
-            it("should prevent unauthenticated users from accessing the ceremonies collection", async () => {
+            /// @note unauthenticated users should be allowed to access ceremonies data
+            it("should allow unauthenticated users from accessing the ceremonies collection", async () => {
                 await expect(
                     queryCollection(userFirestore, commonTerms.collections.ceremonies.name, [
                         where(commonTerms.collections.ceremonies.fields.description, "!=", "")
                     ])
-                ).to.be.rejectedWith("Missing or insufficient permissions.")
+                ).to.be.fulfilled
             })
         }
         // make sure to sign out

packages/actions/test/unit/storage.test.ts

@@ -17,7 +17,7 @@ import {
     cleanUpMockUsers,
     sleep,
     cleanUpRecursively,
-    mockCeremoniesCleanup
+    mockCeremoniesCleanup,
 } from "../utils/index"
 import { fakeCeremoniesData, fakeCircuitsData, fakeUsersData } from "../data/samples"
 import {

packages/backend/firestore.rules

@@ -11,7 +11,7 @@ service cloud.firestore {
     // applies to the ceremonies collection and nested collections
     match /ceremonies/{ceremonyId=**} {
       // any authenticated user can read
-      allow read: if request.auth != null;
+      allow read: if true;
       // only coordinator can create, and update ceremonies
       allow create, update: 
         if request.auth != null && 

packages/backend/src/functions/storage.ts

@@ -476,4 +476,4 @@ export const completeMultiPartUpload = functions
                 logAndThrowError(makeError(commonError.code, commonError.message, additionalDetails))
             }
         }
-    })
+    })

packages/backend/src/types/index.ts

@@ -137,4 +137,4 @@ export type FinalizeCircuitData = {
     circuitId: string
     bucketName: string
     beacon: string
-}
+}