Add Ferret-core #90
Merged
Add Ferret-core #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xiangxiecrypto
commented
Jan 3, 2024
xiangxiecrypto
commented
- Add the core building blocks of Ferret (without network IO).
- It can still be further optimized when integrated with network IO, which needs COT implementation.
|
Let me merge |
|
#87 is merged, you should be able to rebase |
sinui0
requested changes
Mar 7, 2024
Comment on lines
+36
to
+38
| delta: Block, | ||
| lpn_parameters: LpnParameters, | ||
| lpn_type: LpnType, |
There was a problem hiding this comment.
Let us keep it here for now, the new function is only a default instantiation without any specific parameters.
Comment on lines
+38
to
+40
| lpn_parameters: LpnParameters, | ||
| lpn_type: LpnType, | ||
| seed: Block, |
There was a problem hiding this comment.
These can be moved to new as well
| /// * `receiver_msg` - The message that the ideal MPCOT sends to the receiver. | ||
| /// * `alphas` - The positions in each extension. | ||
| /// * `n` - The length of the vector. | ||
| pub fn check( |
There was a problem hiding this comment.
Please pull out into a standalone function gated with #[cfg(test)]
sinui0
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.