-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mpz-common): async sync primitives #152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th4s
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
@themighty1 as per our conversation, i've updated the syncer tests to poll the order more explicitly. |
themighty1
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, nice work!
sinui0
added a commit
that referenced
this pull request
Jun 11, 2024
commit 63a586d Author: sinu.eth <[email protected]> Date: Mon Jun 10 23:09:01 2024 -0700 feat(mpz-ot): impl more OT traits on shared KOS (#153) commit 5a20d29 Author: sinu.eth <[email protected]> Date: Mon Jun 10 23:07:17 2024 -0700 feat(mpz-common): async sync primitives (#152) * feat(mpz-common): async sync primitives * update syncer test * add unsync lock method * update async syncer test commit 86eebbf Author: sinu.eth <[email protected]> Date: Fri Jun 7 09:28:05 2024 -0700 feat(mpz-common): add type alias for test st executor (#154)
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
* feat(mpz-common): async sync primitives * update syncer test * add unsync lock method * update async syncer test
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
* feat(mpz-common): async sync primitives * update syncer test * add unsync lock method * update async syncer test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds async synchronization primitives. I learned that the shared KOS variant needs to be able to hold a lock across an await point.