Add crate mpz-ole-core
#135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sinui0
requested changes
May 14, 2024
th4s
force-pushed
the
add-mpz-ole-core
branch
2 times, most recently
from
54e6667 to
edd298e
Compare
|
Ok I think you can take a look again. I did it similar to |
sinui0
approved these changes
May 16, 2024
sinui0
reviewed
May 20, 2024
themighty1
requested changes
May 24, 2024
|
Thanks! Let's address all of these minus sign comments in one batch. It all boils down to the question, if we implement COPE from the MASCOT paper as is, or if we build upon COPE to implement OLE. The difference is that COPE is Since OLE is the more modern and widely used functionality, I decided for the latter. Can we agree to proceed that way? |
sinui0
approved these changes
May 27, 2024
themighty1
approved these changes
May 29, 2024
Co-authored-by: dan <[email protected]>
- Add default for `BIT_SIZE` - Rename `BitSizeType` -> `BitSize`.
Co-authored-by: dan <[email protected]>
sinui0
pushed a commit
that referenced
this pull request
Jun 25, 2024
* Add generic support for ideal random OT. * Add crate `mpz-ole-core`. * Improved ideal ROT implementation and adapted tests in `mpz-ole-core`. * Remove unnecessary comment. * Add feedback. * Added `Serialize` and `Deserialize` for message types. * Return `Option` instead of `Result`. * Remove unused error enum. * Add transfer id. * Added using `TransferId` in new batch types. * Use `split_off` instead of `drain`. * Return correct number of OLEs from `consume`. * Use `VecDeque` for cache and please clippy. * Use `hybrid-array` and get rid of const generics. * Apply suggestions for improving comments Co-authored-by: dan <[email protected]> * Remove `ByteRepr` from `Field` trait. * Move from `MaskedInput` to `MaskedCorrelation` mental model. * Simplify array creation in `core/sender.rs`. * Add more feedback. - Add default for `BIT_SIZE` - Rename `BitSizeType` -> `BitSize`. * Add comment about which function is evaluated. Co-authored-by: dan <[email protected]> --------- Co-authored-by: dan <[email protected]>
sinui0
pushed a commit
that referenced
this pull request
Jun 25, 2024
* Add generic support for ideal random OT. * Add crate `mpz-ole-core`. * Improved ideal ROT implementation and adapted tests in `mpz-ole-core`. * Remove unnecessary comment. * Add feedback. * Added `Serialize` and `Deserialize` for message types. * Return `Option` instead of `Result`. * Remove unused error enum. * Add transfer id. * Added using `TransferId` in new batch types. * Use `split_off` instead of `drain`. * Return correct number of OLEs from `consume`. * Use `VecDeque` for cache and please clippy. * Use `hybrid-array` and get rid of const generics. * Apply suggestions for improving comments Co-authored-by: dan <[email protected]> * Remove `ByteRepr` from `Field` trait. * Move from `MaskedInput` to `MaskedCorrelation` mental model. * Simplify array creation in `core/sender.rs`. * Add more feedback. - Add default for `BIT_SIZE` - Rename `BitSizeType` -> `BitSize`. * Add comment about which function is evaluated. Co-authored-by: dan <[email protected]> --------- Co-authored-by: dan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the core crate for OLE, and makes ideal random OT more generic.