feat(mpz-common): dummy executor #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themighty1
approved these changes
May 15, 2024
th4s
approved these changes
May 15, 2024
Comment on lines
+74
to
+97
| async fn join<'a, A, B, RA, RB>(&'a mut self, a: A, b: B) -> (RA, RB) | ||
| where | ||
| A: for<'b> FnOnce(&'b mut Self) -> ScopedBoxFuture<'a, 'b, RA> + Send + 'a, | ||
| B: for<'b> FnOnce(&'b mut Self) -> ScopedBoxFuture<'a, 'b, RB> + Send + 'a, | ||
| RA: Send + 'a, | ||
| RB: Send + 'a, | ||
| { | ||
| let a = a(self).await; | ||
| let b = b(self).await; | ||
| (a, b) | ||
| } | ||
|
|
||
| async fn try_join<'a, A, B, RA, RB, E>(&'a mut self, a: A, b: B) -> Result<(RA, RB), E> | ||
| where | ||
| A: for<'b> FnOnce(&'b mut Self) -> ScopedBoxFuture<'a, 'b, Result<RA, E>> + Send + 'a, | ||
| B: for<'b> FnOnce(&'b mut Self) -> ScopedBoxFuture<'a, 'b, Result<RB, E>> + Send + 'a, | ||
| RA: Send + 'a, | ||
| RB: Send + 'a, | ||
| E: Send + 'a, | ||
| { | ||
| let a = a(self).await?; | ||
| let b = b(self).await?; | ||
| Ok((a, b)) | ||
| } |
There was a problem hiding this comment.
Shouldn't these be polled concurrently? Or doesn't it matter because it is only a dummy?
There was a problem hiding this comment.
Doesn't really matter, probably better to do it sequentially to catch any potential deadlocks
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
xiangxiecrypto
pushed a commit
to xiangxiecrypto/mpz
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dummy executor that does nothing.