-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(mpz-ot): Normalize OT and ideal functionalities #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🚀
What is the benefit of adding an extra encapsulation layer for the OT return types in the traits?
It just provides stronger typing and a way to document what each field is. It's better to have the types defined in |
Co-authored-by: th4s <[email protected]>
* add transfer id * update co15 and kos15 * add Output type * feat(mpz-common): ideal functionality utils * refactor ideal functionalities and traits * pr feedback * impl ideal rot * Update crates/mpz-ot/src/ideal/rot.rs Co-authored-by: th4s <[email protected]> --------- Co-authored-by: th4s <[email protected]>
* add transfer id * update co15 and kos15 * add Output type * feat(mpz-common): ideal functionality utils * refactor ideal functionalities and traits * pr feedback * impl ideal rot * Update crates/mpz-ot/src/ideal/rot.rs Co-authored-by: th4s <[email protected]> --------- Co-authored-by: th4s <[email protected]>
This PR normalizes our OT interfaces as well as completely reimplements our ideal functionality abstraction.
Nothing here touches the security critical logic of any of the OT implementations. This is purely a clean up and testing utilities.
Changes
mpz-ot-core
instead of leaking intompz-ot
.mpz-common
TransferId