Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an ideal ROT functionality to mpz-ot-core #102

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

th4s
Copy link
Member

@th4s th4s commented Feb 16, 2024

No description provided.

@th4s th4s requested review from sinui0 and themighty1 February 16, 2024 17:36
@th4s th4s force-pushed the add-ot-core-ideal-rot branch from 47766a1 to 9e137d0 Compare February 20, 2024 12:10
Copy link
Collaborator

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than a few things

ot/mpz-ot-core/src/ideal/ideal_rot.rs Outdated Show resolved Hide resolved
ot/mpz-ot-core/src/ideal/ideal_rot.rs Outdated Show resolved Hide resolved
ot/mpz-ot-core/src/ideal/ideal_rot.rs Outdated Show resolved Hide resolved
ot/mpz-ot-core/src/ideal/ideal_rot.rs Outdated Show resolved Hide resolved
@th4s th4s force-pushed the add-ot-core-ideal-rot branch from ccce5dd to ad39a0a Compare February 27, 2024 09:35
@th4s th4s changed the base branch from dev to refactor/io-ot-traits February 27, 2024 09:38
@th4s
Copy link
Member Author

th4s commented Feb 28, 2024

I will wait for the IO refactor before merging this.

@th4s th4s force-pushed the add-ot-core-ideal-rot branch from ad39a0a to c70c750 Compare March 7, 2024 09:52
@th4s th4s changed the base branch from refactor/io-ot-traits to refactor/mpz-ot March 7, 2024 11:57
@sinui0 sinui0 force-pushed the refactor/mpz-ot branch from b62fa44 to d62a404 Compare March 7, 2024 16:21
Base automatically changed from refactor/mpz-ot to threading-refactor March 7, 2024 16:38
@th4s th4s force-pushed the add-ot-core-ideal-rot branch from c70c750 to 950c87b Compare March 7, 2024 17:02
@sinui0
Copy link
Collaborator

sinui0 commented Mar 7, 2024

lgtm

@th4s th4s merged commit 00cd519 into threading-refactor Mar 7, 2024
sinui0 added a commit that referenced this pull request Apr 30, 2024
* Adds an ideal ROT functionality to mpz-ot-core

* Update ot/mpz-ot-core/src/ideal/ideal_rot.rs

Derive Debug for IdealROT

Co-authored-by: sinu.eth <[email protected]>

* Add feedback

* Add more feedback

---------

Co-authored-by: sinu.eth <[email protected]>
@sinui0 sinui0 deleted the add-ot-core-ideal-rot branch June 6, 2024 16:15
sinui0 added a commit that referenced this pull request Jun 25, 2024
* Adds an ideal ROT functionality to mpz-ot-core

* Update ot/mpz-ot-core/src/ideal/ideal_rot.rs

Derive Debug for IdealROT

Co-authored-by: sinu.eth <[email protected]>

* Add feedback

* Add more feedback

---------

Co-authored-by: sinu.eth <[email protected]>
sinui0 added a commit that referenced this pull request Jun 25, 2024
* Adds an ideal ROT functionality to mpz-ot-core

* Update ot/mpz-ot-core/src/ideal/ideal_rot.rs

Derive Debug for IdealROT

Co-authored-by: sinu.eth <[email protected]>

* Add feedback

* Add more feedback

---------

Co-authored-by: sinu.eth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants