-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds an ideal ROT functionality to mpz-ot-core #102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th4s
force-pushed
the
add-ot-core-ideal-rot
branch
from
February 20, 2024 12:10
47766a1
to
9e137d0
Compare
sinui0
requested changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm other than a few things
sinui0
reviewed
Feb 21, 2024
sinui0
approved these changes
Feb 22, 2024
th4s
force-pushed
the
add-ot-core-ideal-rot
branch
from
February 27, 2024 09:35
ccce5dd
to
ad39a0a
Compare
themighty1
approved these changes
Feb 28, 2024
I will wait for the IO refactor before merging this. |
th4s
force-pushed
the
add-ot-core-ideal-rot
branch
from
March 7, 2024 09:52
ad39a0a
to
c70c750
Compare
Derive Debug for IdealROT Co-authored-by: sinu.eth <[email protected]>
th4s
force-pushed
the
add-ot-core-ideal-rot
branch
from
March 7, 2024 17:02
c70c750
to
950c87b
Compare
lgtm |
sinui0
added a commit
that referenced
this pull request
Apr 30, 2024
* Adds an ideal ROT functionality to mpz-ot-core * Update ot/mpz-ot-core/src/ideal/ideal_rot.rs Derive Debug for IdealROT Co-authored-by: sinu.eth <[email protected]> * Add feedback * Add more feedback --------- Co-authored-by: sinu.eth <[email protected]>
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
* Adds an ideal ROT functionality to mpz-ot-core * Update ot/mpz-ot-core/src/ideal/ideal_rot.rs Derive Debug for IdealROT Co-authored-by: sinu.eth <[email protected]> * Add feedback * Add more feedback --------- Co-authored-by: sinu.eth <[email protected]>
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
* Adds an ideal ROT functionality to mpz-ot-core * Update ot/mpz-ot-core/src/ideal/ideal_rot.rs Derive Debug for IdealROT Co-authored-by: sinu.eth <[email protected]> * Add feedback * Add more feedback --------- Co-authored-by: sinu.eth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.