fix: deadlock for garble-vm (#197)

* fix(garble): do not hang when output is used as input * fix(garble): fix hanging in preprocessing * fix: adapt `is_committed` to consider complete outputs
privacy-scaling-explorations · Dec 13, 2024 · 0eab0be · 0eab0be
1 parent 67e6295
commit 0eab0be
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/crates/mpz-garble-core/src/view.rs b/crates/mpz-garble-core/src/view.rs
@@ -216,7 +216,7 @@ impl View {
     }
 
     pub(crate) fn is_committed(&self, range: Range) -> bool {
-        range.is_subset(&self.input.complete)
+        range.is_subset(&self.input.complete) || range.is_subset(&self.output.complete)
     }
 
     pub(crate) fn commit(&mut self, range: Range) -> Result<()> {

diff --git a/crates/mpz-garble/src/protocol/semihonest/evaluator.rs b/crates/mpz-garble/src/protocol/semihonest/evaluator.rs
@@ -57,6 +57,7 @@ impl<COT> Evaluator<COT> {
                     idx_outputs |= output.to_range();
                     true
                 } else {
+                    idx_outputs |= output.to_range();
                     false
                 }
             })
-Original file line number
+Diff line change
@@ Expand Up / @@ -57,6 +57,7 @@ impl<COT> Evaluator<COT> { @@
                         idx_outputs |= output.to_range();
                         true
                     } else {
+                        idx_outputs |= output.to_range();
                         false
                     }
                 })
@@ Expand Down @@