Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in static memory address #8

Closed
wants to merge 1 commit into from

Conversation

kitounliu
Copy link

The computation of vk_mptr needs to consider the size of instance, otherwise hash_mptr may overflow when reading instance.

@han0110
Copy link
Collaborator

han0110 commented Nov 30, 2023

Hi, thanks a lot for pointing out the issue and the fix! But this PR only fixes the verifier with vk embedded, if vk is separated with dynamic size of instances, for some case it could still overflow vk's memory.

So I did another fix to consider that case in #9, would like to hear your feedback to see if it works for your case.

@han0110
Copy link
Collaborator

han0110 commented Dec 7, 2023

Resolved by #9

@han0110 han0110 closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants