fix: make sure accumulator coordinates are less than base field modulus

privacy-scaling-explorations · Feb 2, 2024 · 43dada6 · 43dada6
1 parent 2ab5ecf
commit 43dada6
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/templates/Halo2Verifier.sol b/templates/Halo2Verifier.sol
@@ -367,7 +367,9 @@ contract Halo2Verifier {
                         shift := add(shift, num_limb_bits)
                     }
 
+                    success := and(success, and(lt(lhs_x, q), lt(lhs_y, q)))
                     success := and(success, eq(mulmod(lhs_y, lhs_y, q), addmod(mulmod(lhs_x, mulmod(lhs_x, lhs_x, q), q), 3, q)))
+                    success := and(success, and(lt(rhs_x, q), lt(rhs_y, q)))
                     success := and(success, eq(mulmod(rhs_y, rhs_y, q), addmod(mulmod(rhs_x, mulmod(rhs_x, rhs_x, q), q), 3, q)))
 
                     mstore(ACC_LHS_X_MPTR, lhs_x)