Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): split project page tabs into individual components #130

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

numtel
Copy link
Contributor

@numtel numtel commented Sep 10, 2024

I want to do something about the performance of this site (that Semaphore v4 page hangs my firefox for a minute) but I had to start here, breaking up the giant ProjectPage tabs into individual components so it's easier to reason about what's going on. That file is now less than half as long and contains many fewer imports.

I haven't looked into what's causing the slowdown yet but this is a start in that direction.

@numtel
Copy link
Contributor Author

numtel commented Sep 11, 2024

With these last three commits, the Semaphore v4 page loads much faster and has no hangups. I did 100 contributions per page and it seems fine. Much better than ~11300 being loaded in the background all at once

This pagination is at the top and bottom of the contributions list:

Screenshot from 2024-09-10 22-22-54

@0xjei
Copy link
Member

0xjei commented Sep 19, 2024

With these last three commits, the Semaphore v4 page loads much faster and has no hangups. I did 100 contributions per page and it seems fine. Much better than ~11300 being loaded in the background all at once

This pagination is at the top and bottom of the contributions list:

Screenshot from 2024-09-10 22-22-54

amazing work @numtel just one quick q: on your screenshoot I see "page 1 of 113", is something you're missing on the pagination side? I think the pages should be just 4 since we had 389 contributions.

@numtel
Copy link
Contributor Author

numtel commented Sep 19, 2024

There's 32 circuits and not all of them had the full 389 contributions. 389 * 32 = 12448

@0xjei
Copy link
Member

0xjei commented Sep 19, 2024

There's 32 circuits and not all of them had the full 389 contributions. 389 * 32 = 12448

mmm I think this is pretty hard to navigate though. Does it make sense to add a filter (e.g., circuit, # of contribution) or something like that to easy the navigation and pagination?

Another idea can be

all (default) circuit1 circuit2 ... circuit32

@numtel
Copy link
Contributor Author

numtel commented Sep 19, 2024

I had thought about that type of navigation but the contribution data doesn't explicitly include the related circuit so I didn't want to parse the filename. But looking at it again, I realized that it wouldn't be too bad.

In the newly added commit, I changed it to a select drop down of each circuit available.

Screenshot from 2024-09-19 10-05-11

@0xjei
Copy link
Member

0xjei commented Sep 19, 2024

I had thought about that type of navigation but the contribution data doesn't explicitly include the related circuit so I didn't want to parse the filename. But looking at it again, I realized that it wouldn't be too bad.

In the newly added commit, I changed it to a select drop down of each circuit available.

Screenshot from 2024-09-19 10-05-11

definitely better, this works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants