-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): split project page tabs into individual components #130
base: main
Are you sure you want to change the base?
chore(web): split project page tabs into individual components #130
Conversation
amazing work @numtel just one quick q: on your screenshoot I see "page 1 of 113", is something you're missing on the pagination side? I think the pages should be just 4 since we had 389 contributions. |
There's 32 circuits and not all of them had the full 389 contributions. 389 * 32 = 12448 |
mmm I think this is pretty hard to navigate though. Does it make sense to add a filter (e.g., circuit, # of contribution) or something like that to easy the navigation and pagination? Another idea can be all (default) circuit1 circuit2 ... circuit32 |
I had thought about that type of navigation but the contribution data doesn't explicitly include the related circuit so I didn't want to parse the filename. But looking at it again, I realized that it wouldn't be too bad. In the newly added commit, I changed it to a select drop down of each circuit available. |
definitely better, this works for me |
I want to do something about the performance of this site (that Semaphore v4 page hangs my firefox for a minute) but I had to start here, breaking up the giant
ProjectPage
tabs into individual components so it's easier to reason about what's going on. That file is now less than half as long and contains many fewer imports.I haven't looked into what's causing the slowdown yet but this is a start in that direction.