Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use pascalCase Slice type for <SliceZone> resolver #109

Merged
merged 6 commits into from
Jan 13, 2022

Conversation

angeloashmore
Copy link
Member

@angeloashmore angeloashmore commented Jan 13, 2022

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

<SliceZone>'s resolve prop is provided as a way to ease migration from next-slicezone. next-slicezone's component uses a resolver function to convert a Slice's type to a React component. In this process, it converts the slice_type property into a pascalcased version.

This PR fixes a compatiblity issue by adding the pascalcase conversion.

Note: The resolver prop will be removed in a future version. When the prop is removed, the changes in this PR will also be removed.

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

🐫

@angeloashmore
Copy link
Member Author

This is published in a pre-release version: v2.0.3-debug.0.

@codecov-commenter
Copy link

Codecov Report

Merging #109 (dbf6e76) into master (33dea53) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   92.36%   92.39%   +0.02%     
==========================================
  Files          15       15              
  Lines         262      263       +1     
  Branches       58       58              
==========================================
+ Hits          242      243       +1     
  Misses          5        5              
  Partials       15       15              
Impacted Files Coverage Δ
src/SliceZone.tsx 86.95% <100.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33dea53...dbf6e76. Read the comment docs.

@angeloashmore angeloashmore merged commit a2f2c23 into master Jan 13, 2022
@angeloashmore angeloashmore deleted the aa/pascalcase-resolver branch January 13, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants