-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types issues with getByUIDs
method
#246
Comments
Hi @sarunast, thanks for reporting this. You are correct; that was unintentional. Your example should work as expected. I fixed the issue in PR #247, but before publishing as latest, would you mind testing it out in your project? I published the changes in an alpha version ( You can install the latest alpha with the following command: npm install @prismicio/client@alpha Once it is confirmed to be working, I'll merge in the fix and publish. Thanks! 🙂 |
The fix has been merged and published in You can upgrade to the latest version with the following command: npm install @prismicio/client@latest @sarunast I confirmed the fix on my side, but please let me know if it did not fix your project. Thanks again for reporting the issue. 🙂 |
Versions
Reproduction
The new type change is breaking the previous type implementation of the method
getByUIDs
. The issue is visble on the code sandbox: https://codesandbox.io/s/keen-tess-znklvs?file=/src/index.ts. If you move the types tocreateClient
it works. I don't think this is expected behavior based on this PR: #238The text was updated successfully, but these errors were encountered: