Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that test actually fails when things are broken #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SevInf
Copy link

@SevInf SevInf commented May 10, 2024

Test could never actually fail, because the only thing it doess is
checks that test_indicator element exists and that element was shown
regardless of test result. Fixed that by giving different test ids to
success and failure indicators.

At the moment, tests deliberately fail because custom databases are not
supported.

Test could never actually fail, because the only thing it doess is
checks that `test_indicator` element exists and that element was shown
regardless of test result. Fixed that by giving different test ids to
success and failure indicators.

At the moment, tests deliberately fail because custom databases are not
supported.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants