This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
We don't need to use our fork of mysql anymore #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
reviewed
Feb 21, 2023
There was a problem hiding this comment.
Like we discussed in DMs, I'm worried about the potential for this silently breaking. Do you feel comfortable like this, or should we go with cargo deny and a strict rule for tokio-native-tls? I think we'll want cargo deny for one reason or another, might as well start now.
|
Cargy deny wants us to separately list all skipped crates from the checks, which is just way too much work for everybody. We decided on Slack to look into dupes for tls stuff in the PR reviews and merge this now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just defining the features for tls crates in quaint is enough.