Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

chore: sort query params #314

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: sort query params #314

wants to merge 4 commits into from

Conversation

janpio
Copy link
Contributor

@janpio janpio commented Aug 19, 2021

This PR resorts some code and docs by applying some "order" to the query params and related code:

  1. General database options
  2. SSL Options
  3. Connection related things (Timeout, Pool)
  4. Sockets
  5. Internal/advanced config

Along the was some small bugs were also fixed (see comments).

@@ -76,14 +82,17 @@
//! - `sslaccept` either `strict` or `accept_invalid_certs`. If strict, the
//! certificate needs to be valid and in the CA certificates.
//! `accept_invalid_certs` accepts any certificate from the server and can
//! lead to weakened security. Defaults to `strict`.
//! lead to weakened security. Defaults to `accept_invalid_certs`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was documented wrong until now.

Comment on lines -122 to -123
/// - `connectionLimit` defines the maximum number of connections opened to the
/// database.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No connectionLimit in single I assume.

@janpio janpio marked this pull request as ready for review August 20, 2021 17:55
@janpio janpio requested a review from pimeys August 20, 2021 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant