This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
force-pushed
the
mssql-support
branch
3 times, most recently
from
May 14, 2020 12:18
d860390
to
8c721cb
Compare
pimeys
force-pushed
the
mssql-support
branch
4 times, most recently
from
May 27, 2020 17:07
0b39d75
to
a6c3b3e
Compare
pimeys
force-pushed
the
mssql-support
branch
5 times, most recently
from
May 28, 2020 14:54
015dc03
to
0aafa5d
Compare
tomhoule
approved these changes
May 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On first read-through it looks good! It's a ton of work, congratulations. I definitely couldn't pay attention to every single line of course.
pimeys
force-pushed
the
mssql-support
branch
3 times, most recently
from
June 8, 2020 14:11
d4f5118
to
ae0ec9d
Compare
The rules on `INSERT IGNORE INTO` emulation with MERGE are now: - If having uniques in the table, see if we have them in the parameters - If yes, join the `DUAL` table with the value - If no, do we have a default value? - If no, panic. - If yes and the value is a static value, join with this - If yes and the value is autogenerated, do not join with this column - If having a compound index and one of the values is autogen, skip the whole index from the join, we expect now every autogenerated value is unique
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single query support for the SQL Server. For MARS support, we might want a new trait that allows multiple queries in one statement.