Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Microsoft SQL Server Support #131

Merged
merged 16 commits into from
Jun 16, 2020
Merged

Microsoft SQL Server Support #131

merged 16 commits into from
Jun 16, 2020

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented May 7, 2020

Single query support for the SQL Server. For MARS support, we might want a new trait that allows multiple queries in one statement.

@pimeys pimeys force-pushed the mssql-support branch 3 times, most recently from d860390 to 8c721cb Compare May 14, 2020 12:18
@pimeys pimeys force-pushed the mssql-support branch 4 times, most recently from 0b39d75 to a6c3b3e Compare May 27, 2020 17:07
@pimeys pimeys added this to the Beta 7 milestone May 28, 2020
@pimeys pimeys self-assigned this May 28, 2020
@pimeys pimeys added the kind/feature A request for a new feature. label May 28, 2020
@pimeys pimeys force-pushed the mssql-support branch 5 times, most recently from 015dc03 to 0aafa5d Compare May 28, 2020 14:54
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On first read-through it looks good! It's a ton of work, congratulations. I definitely couldn't pay attention to every single line of course.

src/ast/column.rs Show resolved Hide resolved
src/ast/insert.rs Show resolved Hide resolved
src/ast/row.rs Show resolved Hide resolved
src/connector/connection_info.rs Outdated Show resolved Hide resolved
src/connector/mssql/error.rs Show resolved Hide resolved
src/connector/mysql/conversion.rs Show resolved Hide resolved
src/connector/queryable.rs Show resolved Hide resolved
src/pooled.rs Show resolved Hide resolved
@janpio janpio modified the milestones: Beta 7, Beta 8 Jun 2, 2020
@pimeys pimeys force-pushed the mssql-support branch 3 times, most recently from d4f5118 to ae0ec9d Compare June 8, 2020 14:11
Julius de Bruijn added 6 commits June 12, 2020 18:00
The rules on `INSERT IGNORE INTO` emulation with MERGE are now:

- If having uniques in the table, see if we have them in the parameters
- If yes, join the `DUAL` table with the value
- If no, do we have a default value?
- If no, panic.
- If yes and the value is a static value, join with this
- If yes and the value is autogenerated, do not join with this column
- If having a compound index and one of the values is autogen, skip the
  whole index from the join, we expect now every autogenerated value is unique
@pimeys pimeys modified the milestones: Beta 10, 2.1.0 Jun 15, 2020
@pimeys pimeys merged commit 91d2dc2 into master Jun 16, 2020
@pimeys pimeys deleted the mssql-support branch June 16, 2020 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature A request for a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants