fix(D1): numerical filters and aggregations + emulated referential actions #4970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkomyno
commented
Jul 31, 2024
WASM Query Engine file Size
|
This comment was marked as outdated.
This comment was marked as outdated.
SevInf
reviewed
Aug 7, 2024
jkomyno
commented
Aug 7, 2024
CodSpeed Performance ReportMerging #4970 will not alter performanceComparing Summary
|
SevInf
reviewed
Aug 7, 2024
SevInf
approved these changes
Aug 8, 2024
alexolivier
referenced
this pull request
in cerbos/query-plan-adapters
Sep 25, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@cerbos/grpc](https://redirect.github.com/cerbos/cerbos-sdk-javascript/tree/main/packages/grpc#readme) ([source](https://redirect.github.com/cerbos/cerbos-sdk-javascript/tree/HEAD/packages/grpc)) | [`0.18.1` -> `0.18.3`](https://renovatebot.com/diffs/npm/@cerbos%2fgrpc/0.18.1/0.18.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@prisma/client](https://www.prisma.io) ([source](https://redirect.github.com/prisma/prisma/tree/HEAD/packages/client)) | [`5.17.0` -> `5.20.0`](https://renovatebot.com/diffs/npm/@prisma%2fclient/5.17.0/5.20.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/jest](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/jest) ([source](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest)) | [`29.5.12` -> `29.5.13`](https://renovatebot.com/diffs/npm/@types%2fjest/29.5.12/29.5.13) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/node](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | [`20.14.14` -> `20.16.7`](https://renovatebot.com/diffs/npm/@types%2fnode/20.14.14/20.16.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [mongoose](https://mongoosejs.com) ([source](https://redirect.github.com/Automattic/mongoose)) | [`8.5.2` -> `8.6.3`](https://renovatebot.com/diffs/npm/mongoose/8.5.2/8.6.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [prisma](https://www.prisma.io) ([source](https://redirect.github.com/prisma/prisma/tree/HEAD/packages/cli)) | [`5.17.0` -> `5.20.0`](https://renovatebot.com/diffs/npm/prisma/5.17.0/5.20.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [ts-jest](https://kulshekhar.github.io/ts-jest) ([source](https://redirect.github.com/kulshekhar/ts-jest)) | [`29.2.4` -> `29.2.5`](https://renovatebot.com/diffs/npm/ts-jest/29.2.4/29.2.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [typescript](https://www.typescriptlang.org/) ([source](https://redirect.github.com/microsoft/TypeScript)) | [`5.5.4` -> `5.6.2`](https://renovatebot.com/diffs/npm/typescript/5.5.4/5.6.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>cerbos/cerbos-sdk-javascript (@​cerbos/grpc)</summary> ### [`v0.18.3`](https://redirect.github.com/cerbos/cerbos-sdk-javascript/blob/HEAD/packages/grpc/CHANGELOG.md#0183---2024-09-23) [Compare Source](https://redirect.github.com/cerbos/cerbos-sdk-javascript/compare/@cerbos/[email protected]...@cerbos/[email protected]) ##### Changed - Bump dependency on \[[@​bufbuild/protobuf](https://redirect.github.com/bufbuild/protobuf)] to 2.1.0 ([#​1012](https://redirect.github.com/cerbos/cerbos-sdk-javascript/pull/1012)) - Bump dependency on \[[@​grpc/grpc-js](https://redirect.github.com/grpc/grpc-js)] to 1.11.3 ([#​1000](https://redirect.github.com/cerbos/cerbos-sdk-javascript/pull/1000), [#​1011](https://redirect.github.com/cerbos/cerbos-sdk-javascript/pull/1011)) ### [`v0.18.2`](https://redirect.github.com/cerbos/cerbos-sdk-javascript/blob/HEAD/packages/grpc/CHANGELOG.md#0182---2024-08-19) [Compare Source](https://redirect.github.com/cerbos/cerbos-sdk-javascript/compare/@cerbos/[email protected]...@cerbos/[email protected]) ##### Changed - Replace dependency on \[protobufjs] with \[[@​bufbuild/protobuf](https://redirect.github.com/bufbuild/protobuf)] ([#​990](https://redirect.github.com/cerbos/cerbos-sdk-javascript/pull/990)) - Bump dependency on \[[@​grpc/grpc-js](https://redirect.github.com/grpc/grpc-js)] to 1.11.1 ([#​974](https://redirect.github.com/cerbos/cerbos-sdk-javascript/pull/974), [#​979](https://redirect.github.com/cerbos/cerbos-sdk-javascript/pull/979), [#​981](https://redirect.github.com/cerbos/cerbos-sdk-javascript/pull/981)) </details> <details> <summary>prisma/prisma (@​prisma/client)</summary> ### [`v5.20.0`](https://redirect.github.com/prisma/prisma/releases/tag/5.20.0) [Compare Source](https://redirect.github.com/prisma/prisma/compare/5.19.1...5.20.0) 🌟 **Help us spread the word about Prisma by starring the repo or [posting on X](https://twitter.com/intent/tweet?text=Check%20out%20the%20latest%20@​prisma%20release%20v5.20.0%20%F0%9F%9A%80%0D%0A%0D%0Ahttps://github.com/prisma/prisma/releases/tag/5.20.0) about the release.** 🌟 #### Highlights ##### `strictUndefinedChecks` in Preview With Prisma ORM 5.20.0, the Preview feature `strictUndefinedChecks` will disallow any value that is explicitly `undefined` and will be a runtime error. This change is direct feedback from [this GitHub issue](https://redirect.github.com/prisma/prisma/issues/20169) and follows [our latest proposal](https://redirect.github.com/prisma/prisma/issues/20169#issuecomment-2338360300) on the same issue. To demonstrate the change, take the following code snippet: ```tsx prisma.table.deleteMany({ where: { // If `nullableThing` is nullish, this query will remove all data. email: nullableThing?.property, } }) ``` In Prisma ORM 5.19.0 and below, this could result in unintended behavior. In Prisma ORM 5.20.0, if the `strictUndefinedChecks` Preview feature is enabled, you will get a runtime error instead: ```tsx Invalid \`prisma.user.findMany()\` invocation in /client/tests/functional/strictUndefinedChecks/test.ts:0:0 XX }) XX XX test('throws on undefined input field', async () => { → XX const result = prisma.user.deleteMany({ where: { email: undefined ~~~~~~~~~ } }) Invalid value for argument \`where\`: explicitly \`undefined\` values are not allowed." ``` We have also introduced the `Prisma.skip` symbol, which will allow you to get the previous behavior if desired. ```tsx prisma.table.findMany({ where: { // Use Prisma.skip to skip parts of the query email: nullableEmail ?? Prisma.skip } }) ``` From Prisma ORM 5.20.0 onward, we recommend enabling `strictUndefinedChecks`, along with the TypeScript compiler option `exactOptionalPropertyTypes`, which will help catch cases of undefined values at compile time. Together, these two changes will help protect your Prisma queries from potentially destructive behavior. `strictUndefinedChecks` will be a valid Preview feature for the remainder of Prisma ORM 5. With our next major version, this behavior will become the default and the Preview feature will be “graduated” to Generally Available. If you have any questions or feedback about `strictUndefinedChecks`, please ask/comment in our dedicated [Preview feature GitHub discussion](https://redirect.github.com/prisma/prisma/discussions/25271). ##### `typedSql` bug fix Thank you to everyone who has tried out our [`typedSql` Preview feature](https://www.prisma.io/blog/announcing-typedsql-make-your-raw-sql-queries-type-safe-with-prisma-orm) and [provided feedback](https://redirect.github.com/prisma/prisma/discussions/25106)! This release has a quick fix for typescript files generated when Prisma Schema enums had hyphens. #### Fixes and improvements ##### Prisma - [Prisma incorrectly parses CRDB's FK constraint error as `not available`.](https://redirect.github.com/prisma/prisma/issues/24072) - [Invalid TypeScript files created by `generate` when typedSql is enabled and enum contains hyphens.](https://redirect.github.com/prisma/prisma/issues/25163) - [`@prisma/internals` didn't list `ts-toolbelt` in dependencies.](https://redirect.github.com/prisma/prisma/issues/17952) - [using `$extends` prevents model comments from being passed to TypeScript](https://redirect.github.com/prisma/prisma/issues/24648) ##### Prisma Engines - [Planetscale engine tests: interactive_tx](https://redirect.github.com/prisma/prisma-engines/issues/4469) - [Fix broken engine size publishing workflow](https://redirect.github.com/prisma/prisma-engines/issues/4991) #### Credits Huge thanks to [@​mcuelenaere](https://redirect.github.com/mcuelenaere), [@​pagewang0](https://redirect.github.com/pagewang0), [@​key-moon](https://redirect.github.com/key-moon), [@​pranayat](https://redirect.github.com/pranayat), [@​yubrot](https://redirect.github.com/yubrot), [@​thijmenjk](https://redirect.github.com/thijmenjk), [@​mydea](https://redirect.github.com/mydea), [@​HRM](https://redirect.github.com/HRM), [@​haaawk](https://redirect.github.com/haaawk), [@​baileywickham](https://redirect.github.com/baileywickham), [@​brian-dlee](https://redirect.github.com/brian-dlee), [@​nickcarnival](https://redirect.github.com/nickcarnival), [@​eruditmorina](https://redirect.github.com/eruditmorina), [@​nzakas](https://redirect.github.com/nzakas), and [@​gutyerrez](https://redirect.github.com/gutyerrez) for helping! ### [`v5.19.1`](https://redirect.github.com/prisma/prisma/releases/tag/5.19.1) [Compare Source](https://redirect.github.com/prisma/prisma/compare/5.19.0...5.19.1) Today, we are issuing the `5.19.1` patch release. #### What's Changed We've fixed the following issues: - [https://github.com/prisma/prisma/issues/25103](https://redirect.github.com/prisma/prisma/issues/25103) - [https://github.com/prisma/prisma/issues/25137](https://redirect.github.com/prisma/prisma/issues/25137) - [https://github.com/prisma/prisma/issues/25104](https://redirect.github.com/prisma/prisma/issues/25104) - [https://github.com/prisma/prisma/issues/25101](https://redirect.github.com/prisma/prisma/issues/25101) **Full Changelog**: prisma/prisma@5.19.0...5.19.x, prisma/prisma-engines@5.19.0...5.19.x ### [`v5.19.0`](https://redirect.github.com/prisma/prisma/releases/tag/5.19.0) [Compare Source](https://redirect.github.com/prisma/prisma/compare/5.18.0...5.19.0) Today, we are excited to share the `5.19.0` stable release 🎉 🌟 **Help us spread the word about Prisma by starring the repo or [posting on X](https://twitter.com/intent/tweet?text=Check%20out%20the%20latest%20@​prisma%20release%20v5.19.0%20%F0%9F%9A%80%0D%0A%0D%0Ahttps://github.com/prisma/prisma/releases/tag/5.19.0) about the release.** 🌟 #### Highlights ##### Introducing TypedSQL TypedSQL is a brand new way to interact with your database from Prisma Client. After enabling the `typedSql` Preview feature, you’re able to write SQL queries in a new `sql` subdirectory of your `prisma` directory. These queries are then checked by Prisma during using the new `--sql` flag of `prisma generate` and added to your client for use in your code. To get started with TypedSQL: 1. Make sure that you have the latest version of `prisma` and `@prisma/client` installed: npm install -D prisma@latest npm install @​prisma/client@latest 2. Enable the `typedSql` Preview feature in your Prisma Schema. generator client { provider = "prisma-client-js" previewFeatures = ["typedSql"] } 3. Create a `sql` subdirectory of your `prisma` directory. mkdir -p prisma/sql 4. You can now add `.sql` files to the `sql` directory! Each file can contain one sql query and the name must be a valid JS identifier. For this example, say you had the file `getUsersWithPosts.sql` with the following contents: ```sql SELECT u.id, u.name, COUNT(p.id) as "postCount" FROM "User" u LEFT JOIN "Post" p ON u.id = p."authorId" GROUP BY u.id, u.name ``` 5. Import your SQL query into your code with the `@prisma/client/sql` import: ```tsx import { PrismaClient } from '@​prisma/client' import { getUsersWithPosts } from '@​prisma/client/sql' const prisma = new PrismaClient() const usersWithPostCounts = await prisma.$queryRawTyped(getUsersWithPosts) console.log(usersWithPostCounts) ``` There’s a lot more to talk about with TypedSQL. We think that the combination of the high-level Prisma Client API and the low-level TypedSQL will make for a great developer experience for all of our users. To learn more about behind the “why” of TypedSQL [be sure to check out our announcement blog post](https://pris.ly/typedsql-blog). For docs, check out our new [TypedSQL section](https://pris.ly/d/typedsql). #### Bug fixes ##### Driver adapters and D1 A few issues with our `driverAdapters` Preview feature and Cloudflare D1 support were resolved via [https://github.com/prisma/prisma-engines/pull/4970](https://redirect.github.com/prisma/prisma-engines/pull/4970) and [https://github.com/prisma/prisma/pull/24922](https://redirect.github.com/prisma/prisma/pull/24922) - Mathematic operations such as `max`, `min`, `eq`, etc in queries when using Cloudflare D1. - Resolved issues when comparing `BigInt` IDs when `relationMode="prisma"` was enabled and Cloudflare D1 was being used. ##### Joins - [https://github.com/prisma/prisma/issues/23742](https://redirect.github.com/prisma/prisma/issues/23742) fixes Prisma Client not supporting deeply nested `some` clauses when the `relationJoins` Preview feature was enabled. #### Join us Looking to make an impact on Prisma in a big way? We're now hiring engineers for the ORM team! - [Senior Engineer (TypeScript)](https://boards.greenhouse.io/prisma/jobs/5350820002): This person will be primarily working on the TypeScript side and evolving our Prisma client. Rust knowledge (or desire to learn Rust) is a plus. - [Senior Engineer (Rust)](https://boards.greenhouse.io/prisma/jobs/6940273002): This person will be focused on the `prisma-engines` Rust codebase. TypeScript knowledge (or, again, a desire to learn) is a plus. #### Credits Huge thanks to [@​mcuelenaere](https://redirect.github.com/mcuelenaere), [@​pagewang0](https://redirect.github.com/pagewang0), [@​Druue](https://redirect.github.com/Druue), [@​key-moon](https://redirect.github.com/key-moon), [@​Jolg42](https://redirect.github.com/Jolg42), [@​pranayat](https://redirect.github.com/pranayat), [@​ospfranco](https://redirect.github.com/ospfranco), [@​yubrot](https://redirect.github.com/yubrot), [@​skyzh](https://redirect.github.com/skyzh) for helping! ### [`v5.18.0`](https://redirect.github.com/prisma/prisma/releases/tag/5.18.0) [Compare Source](https://redirect.github.com/prisma/prisma/compare/5.17.0...5.18.0) 🌟 **Help us spread the word about Prisma by starring the repo or [tweeting](https://twitter.com/intent/tweet?text=Check%20out%20the%20latest%20@​prisma%20release%20v5.18.0%20%F0%9F%9A%80%0D%0A%0D%0Ahttps://github.com/prisma/prisma/releases/tag/5.18.0) about the release.** 🌟 ##### Highlights ##### Native support for UUIDv7 Previous to this release, the Prisma Schema function `uuid()` did not accept any arguments and created a UUIDv4 ID. While sufficient in many cases, UUIDv4 has a few drawbacks, namely that it is not temporally sortable. UUIDv7 attempts to resolve this issue, making it easy to temporally sort your database rows by ID! To support this, we’ve updated the `uuid()` function in Prisma Schema to accept an optional, integer argument. Right now, the only valid values are `4` and `7`, with `4` being the default. ```tsx model User { id String @​id @​default(uuid()) // defaults to 4 name String } model User { id String @​id @​default(uuid(4)) // same as above, but explicit name String } model User { id String @​id @​default(uuid(7)) // will use UUIDv7 instead of UUIDv4 name String } ``` ##### Bug squashing We’ve squashed a number of bugs this release, special thanks to everyone who helped us! A few select highlights are: - [SQLite db will now be created and read from the correct location when using `prismaSchemaFolder`](https://redirect.github.com/prisma/prisma/issues/24779). - [Empty `Json[]` fields will now return `[]` instead of `null` when accessed through a join using the `relationJoins` Preview feature.](https://redirect.github.com/prisma/prisma/issues/22923) ##### Fixes and improvements ##### Prisma - [Support UUID v7](https://redirect.github.com/prisma/prisma/issues/24079) ##### Language tools (e.g. VS Code) - [Support fetching references for a model](https://redirect.github.com/prisma/language-tools/issues/982) ##### Credits Huge thanks to [@​mcuelenaere](https://redirect.github.com/mcuelenaere), [@​pagewang0](https://redirect.github.com/pagewang0), [@​Druue](https://redirect.github.com/Druue), [@​key-moon](https://redirect.github.com/key-moon), [@​Jolg42](https://redirect.github.com/Jolg42), [@​pranayat](https://redirect.github.com/pranayat), [@​ospfranco](https://redirect.github.com/ospfranco), [@​yubrot](https://redirect.github.com/yubrot), [@​skyzh](https://redirect.github.com/skyzh), [@​haaawk](https://redirect.github.com/haaawk) for helping! </details> <details> <summary>Automattic/mongoose (mongoose)</summary> ### [`v8.6.3`](https://redirect.github.com/Automattic/mongoose/blob/HEAD/CHANGELOG.md#863--2024-09-17) [Compare Source](https://redirect.github.com/Automattic/mongoose/compare/8.6.2...8.6.3) \================== - fix: make getters convert uuid to string when calling toObject() and toJSON() [#​14890](https://redirect.github.com/Automattic/mongoose/issues/14890) [#​14869](https://redirect.github.com/Automattic/mongoose/issues/14869) - fix: fix missing Aggregate re-exports for ESM [#​14886](https://redirect.github.com/Automattic/mongoose/issues/14886) [wongsean](https://redirect.github.com/wongsean) - types(document): add generic param to depopulate() to allow updating properties [#​14891](https://redirect.github.com/Automattic/mongoose/issues/14891) [#​14876](https://redirect.github.com/Automattic/mongoose/issues/14876) ### [`v8.6.2`](https://redirect.github.com/Automattic/mongoose/blob/HEAD/CHANGELOG.md#862--2024-09-11) [Compare Source](https://redirect.github.com/Automattic/mongoose/compare/8.6.1...8.6.2) \================== - fix: make set merge deeply nested objects [#​14870](https://redirect.github.com/Automattic/mongoose/issues/14870) [#​14861](https://redirect.github.com/Automattic/mongoose/issues/14861) [ianHeydoc](https://redirect.github.com/ianHeydoc) - types: allow arbitrary keys in query filters again (revert [#​14764](https://redirect.github.com/Automattic/mongoose/issues/14764)) [#​14874](https://redirect.github.com/Automattic/mongoose/issues/14874) [#​14863](https://redirect.github.com/Automattic/mongoose/issues/14863) [#​14862](https://redirect.github.com/Automattic/mongoose/issues/14862) [#​14842](https://redirect.github.com/Automattic/mongoose/issues/14842) - types: make SchemaType static setters property accessible in TypeScript [#​14881](https://redirect.github.com/Automattic/mongoose/issues/14881) [#​14879](https://redirect.github.com/Automattic/mongoose/issues/14879) - type(inferrawdoctype): infer Date types as JS dates rather than Mongoose SchemaType Date [#​14882](https://redirect.github.com/Automattic/mongoose/issues/14882) [#​14839](https://redirect.github.com/Automattic/mongoose/issues/14839) ### [`v8.6.1`](https://redirect.github.com/Automattic/mongoose/blob/HEAD/CHANGELOG.md#861--2024-09-03) [Compare Source](https://redirect.github.com/Automattic/mongoose/compare/8.6.0...8.6.1) \================== - fix(document): avoid unnecessary clone() in applyGetters() that was preventing getters from running on 3-level deep subdocuments [#​14844](https://redirect.github.com/Automattic/mongoose/issues/14844) [#​14840](https://redirect.github.com/Automattic/mongoose/issues/14840) [#​14835](https://redirect.github.com/Automattic/mongoose/issues/14835) - fix(model): throw error if bulkSave() did not insert or update any documents [#​14837](https://redirect.github.com/Automattic/mongoose/issues/14837) [#​14763](https://redirect.github.com/Automattic/mongoose/issues/14763) - fix(cursor): throw error in ChangeStream constructor if changeStreamThunk() throws a sync error [#​14846](https://redirect.github.com/Automattic/mongoose/issues/14846) - types(query): add $expr to RootQuerySelector [#​14845](https://redirect.github.com/Automattic/mongoose/issues/14845) - docs: update populate.md to fix missing match: { } [#​14847](https://redirect.github.com/Automattic/mongoose/issues/14847) [makhoulshbeeb](https://redirect.github.com/makhoulshbeeb) ### [`v8.6.0`](https://redirect.github.com/Automattic/mongoose/blob/HEAD/CHANGELOG.md#860--2024-08-28) [Compare Source](https://redirect.github.com/Automattic/mongoose/compare/8.5.5...8.6.0) \================== - feat: upgrade mongodb -> 6.8.0, handle throwing error on closed cursor in Mongoose with `MongooseError` instead of `MongoCursorExhaustedError` [#​14813](https://redirect.github.com/Automattic/mongoose/issues/14813) - feat(model+query): support options parameter for distinct() [#​14772](https://redirect.github.com/Automattic/mongoose/issues/14772) [#​8006](https://redirect.github.com/Automattic/mongoose/issues/8006) - feat(QueryCursor): add getDriverCursor() function that returns the raw driver cursor [#​14745](https://redirect.github.com/Automattic/mongoose/issues/14745) - types: change query selector to disallow unknown top-level keys by default [#​14764](https://redirect.github.com/Automattic/mongoose/issues/14764) [alex-statsig](https://redirect.github.com/alex-statsig) - types: make toObject() and toJSON() not generic by default to avoid type widening [#​14819](https://redirect.github.com/Automattic/mongoose/issues/14819) [#​12883](https://redirect.github.com/Automattic/mongoose/issues/12883) - types: avoid automatically inferring lean result type when assigning to explicitly typed variable [#​14734](https://redirect.github.com/Automattic/mongoose/issues/14734) ### [`v8.5.5`](https://redirect.github.com/Automattic/mongoose/blob/HEAD/CHANGELOG.md#855--2024-08-28) [Compare Source](https://redirect.github.com/Automattic/mongoose/compare/8.5.4...8.5.5) \================== - fix(populate): fix a couple of other places where Mongoose gets the document's \_id with getters [#​14833](https://redirect.github.com/Automattic/mongoose/issues/14833) [#​14827](https://redirect.github.com/Automattic/mongoose/issues/14827) [#​14759](https://redirect.github.com/Automattic/mongoose/issues/14759) - fix(discriminator): shallow clone Schema.prototype.obj before merging schemas to avoid modifying original obj [#​14821](https://redirect.github.com/Automattic/mongoose/issues/14821) - types: fix schema type based on timestamps schema options value [#​14829](https://redirect.github.com/Automattic/mongoose/issues/14829) [#​14825](https://redirect.github.com/Automattic/mongoose/issues/14825) [ark23CIS](https://redirect.github.com/ark23CIS) ### [`v8.5.4`](https://redirect.github.com/Automattic/mongoose/blob/HEAD/CHANGELOG.md#854--2024-08-23) [Compare Source](https://redirect.github.com/Automattic/mongoose/compare/8.5.3...8.5.4) \================== - fix: add empty string check for collection name passed [#​14806](https://redirect.github.com/Automattic/mongoose/issues/14806) [Shubham2552](https://redirect.github.com/Shubham2552) - docs(model): add 'throw' as valid strict value for bulkWrite() and add some more clarification on throwOnValidationError [#​14809](https://redirect.github.com/Automattic/mongoose/issues/14809) ### [`v8.5.3`](https://redirect.github.com/Automattic/mongoose/blob/HEAD/CHANGELOG.md#853--2024-08-13) [Compare Source](https://redirect.github.com/Automattic/mongoose/compare/8.5.2...8.5.3) \================== - fix(document): call required functions on subdocuments underneath nested paths with correct context [#​14801](https://redirect.github.com/Automattic/mongoose/issues/14801) [#​14788](https://redirect.github.com/Automattic/mongoose/issues/14788) - fix(populate): avoid throwing error when no result and `lean()` set [#​14799](https://redirect.github.com/Automattic/mongoose/issues/14799) [#​14794](https://redirect.github.com/Automattic/mongoose/issues/14794) [#​14759](https://redirect.github.com/Automattic/mongoose/issues/14759) [MohOraby](https://redirect.github.com/MohOraby) - fix(document): apply virtuals to subdocuments if parent schema has virtuals: true for backwards compatibility [#​14774](https://redirect.github.com/Automattic/mongoose/issues/14774) [#​14771](https://redirect.github.com/Automattic/mongoose/issues/14771) [#​14623](https://redirect.github.com/Automattic/mongoose/issues/14623) [#​14394](https://redirect.github.com/Automattic/mongoose/issues/14394) - types: make HydratedSingleSubdocument and HydratedArraySubdocument merge types instead of using & [#​14800](https://redirect.github.com/Automattic/mongoose/issues/14800) [#​14793](https://redirect.github.com/Automattic/mongoose/issues/14793) - types: support schema type inference based on schema options timestamps as well [#​14773](https://redirect.github.com/Automattic/mongoose/issues/14773) [#​13215](https://redirect.github.com/Automattic/mongoose/issues/13215) [ark23CIS](https://redirect.github.com/ark23CIS) - types(cursor): indicate that cursor.next() can return null [#​14798](https://redirect.github.com/Automattic/mongoose/issues/14798) [#​14787](https://redirect.github.com/Automattic/mongoose/issues/14787) - types: allow mongoose.connection.db to be undefined [#​14797](https://redirect.github.com/Automattic/mongoose/issues/14797) [#​14789](https://redirect.github.com/Automattic/mongoose/issues/14789) - docs: add schema type widening advice [#​14790](https://redirect.github.com/Automattic/mongoose/issues/14790) [JstnMcBrd](https://redirect.github.com/JstnMcBrd) </details> <details> <summary>kulshekhar/ts-jest (ts-jest)</summary> ### [`v29.2.5`](https://redirect.github.com/kulshekhar/ts-jest/blob/HEAD/CHANGELOG.md#2925-2024-08-23) [Compare Source](https://redirect.github.com/kulshekhar/ts-jest/compare/v29.2.4...v29.2.5) </details> <details> <summary>microsoft/TypeScript (typescript)</summary> ### [`v5.6.2`](https://redirect.github.com/microsoft/TypeScript/compare/v5.5.4...a7e3374f13327483fbe94e32806d65785b0b6cda) [Compare Source](https://redirect.github.com/microsoft/TypeScript/compare/v5.5.4...v5.6.2) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - "after 9am and before 5pm Monday" (UTC). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/cerbos/query-plan-adapters). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Companion PR: prisma/prisma#24922
This PR also fixes the broken linkage between
prisma/prisma-enginesandprisma/prismaby ensuring that theDRIVER_ADAPTERS_BRANCHvariable is only extracted from actual Git head refs, rather than any merge branch.This is what allowed tests in this PR to finally succeed:
Thank you @SevInf for https://prisma-company.slack.com/archives/C03R3PJN004/p1722957691404159?thread_ts=1722440855.494109&cid=C03R3PJN004!