Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qe: start introducing typed identifiers in relations #3672

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

tomhoule
Copy link
Contributor

@tomhoule tomhoule commented Feb 6, 2023

@tomhoule tomhoule requested a review from a team February 6, 2023 12:59
@tomhoule tomhoule requested a review from a team as a code owner February 6, 2023 12:59
/// to be rendered as comments. Since the parser will not set these flags when reading a schema
/// string, only introspection and the lowering of the datamodel to the ast care about these flags.
/// The FieldType: Unsupported behaves in the same way.
/// Both of these are never converted into the internal datamodel.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not accurate anymore.

@tomhoule tomhoule added this to the 4.10.0 milestone Feb 6, 2023
@tomhoule tomhoule force-pushed the qe-typed-identifiers-relations branch from 5a7886e to 305e470 Compare February 6, 2023 13:15
Copy link
Contributor

@Weakky Weakky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomhoule tomhoule merged commit d026664 into main Feb 7, 2023
@tomhoule tomhoule deleted the qe-typed-identifiers-relations branch February 7, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants