chore: (qe) Log capture preparatory refactoring #3616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelff
changed the title
miguelff
force-pushed
the
log-capture-prep-refactoring
branch
2 times, most recently
from
530761c to
914916d
Compare
…uld not change the existing behavior of the engine
miguelff
force-pushed
the
log-capture-prep-refactoring
branch
3 times, most recently
from
5fc71ed to
c144b46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #3505 for easier review.
These changes are aimed at accommodating log capturing without incurring in any change in behavior in the query-engine