query-engine-node-api: delete getConfig() #3608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Prisma CLI now uses getConfig from the @prisma/prisma-fmt-wasm package. This method is not used anymore. We also observe a small size improvement: Before: -r-xr-xr-x 2 root root 14311096 Jan 1 1970 libquery_engine.node After: -r-xr-xr-x 2 root root 14282424 Jan 1 1970 libquery_engine.node amounting to a ~30kb smaller node-api build of the query engine.
|
As discovered while working on prisma/prisma#17443, the Client runtime still uses |
tomhoule
added a commit
that referenced
this pull request
Jan 20, 2023
We deleted getConfig from the node api builds of the query-engine for a 30kb gain with the assumption that it wasn't used at all anymore in the CLI. It is not the case. This reverts commit 7e6991a.
tomhoule
added a commit
that referenced
this pull request
Jan 20, 2023
|
Reverted in #3619 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Prisma CLI now uses getConfig from the @prisma/prisma-fmt-wasm package. This method is not used anymore.
We also observe a small size improvement:
Before:
-r-xr-xr-x 2 root root 14311096 Jan 1 1970 libquery_engine.node
After:
-r-xr-xr-x 2 root root 14282424 Jan 1 1970 libquery_engine.node
amounting to a ~30kb smaller node-api build of the query engine.
closes https://github.com/prisma/client-planning/issues/225