sql-query-connector: take trace ids by reference #3571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is limited to sql-query-connector, it should not interfere with #3505. In general, we do not need ownership of the trace id in sql-query-connector, since we only re-render it in comments. Working with a reference is easier (it ii `Copy`, etc.), and it already saves us string copies and allocations with this commit. The other purpose of this PR is that we discussed yesterday about introducing a `QueryContext<'_>` type struct to hold things like the trace id and connection info. Experience from designing similar context structs in the schema team showed it is much easier to do if everything in the context can be a reference. On the side, I could not resist making a few public items crate-public, to make the public surface of the crate smaller and clearer.
tomhoule
force-pushed
the
sql-query-connector-context
branch
from
ad36b5f to
4986f7a
Compare
pimeys
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is limited to sql-query-connector, it should not interfere with #3505.
In general, we do not need ownership of the trace id in sql-query-connector, since we only re-render it in comments. Working with a reference is easier (it ii
Copy, etc.), and it already saves us string copies and allocations with this commit.The other purpose of this PR is that we discussed yesterday about introducing a
QueryContext<'_>type struct to hold things like the trace id and connection info. Experience from designing similar context structs in the schema team showed it is much easier to do if everything in the context can be a reference.On the side, I could not resist making a few public items crate-public, to make the public surface of the crate smaller and clearer.