fix(migration-engine): changed type of "compositeTypeDepth" from u32 to isize
#3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to isize, fixing type mismatch issues with the TS cli
Jolg42
deleted the
integration/introspect-composite-type-depth-to-isize
branch
jkomyno
added a commit
to prisma/prisma
that referenced
this pull request
Dec 13, 2022
jkomyno
added a commit
to prisma/prisma
that referenced
this pull request
Dec 13, 2022
…ma/prisma-engines#3487 got merged, as the Rust PR doesn't seem to have solved the type mistmatch issue" This reverts commit d6052ec.
1 task
jkomyno
added a commit
to prisma/prisma
that referenced
this pull request
Jan 12, 2023
* feat(migrate-engine): start moving out of introspection-engine * feat(migration-engine): adapted compositeTypeDepth after prisma/prisma-engines#3487 got merged * feat(internals): stop using IntrospectionEngine.getDatabaseDescription, as it hasn't been used in years * feat(integration-tests): replaced IntrospectionEngine with MigrateEngine * feat(migration-engine): add "latestSchema" and "isRunning" properties * feat(migration-engine): add "getDatabaseVersionSafe" util to avoid circular dependencies * feat(cli): plugged "getDatabaseVersionSafe" into "handlePanic" and "sendPanic", avoiding circular dependencies in @prisma/internals. Standardized "engineVersion" into "enginesVersion" * feat(integration-tests): depend on @prisma/migrate * Revert "feat(migration-engine): adapted compositeTypeDepth after prisma/prisma-engines#3487 got merged, as the Rust PR doesn't seem to have solved the type mistmatch issue" This reverts commit d6052ec. * feat(introspection-engine): restore "introspect()" now that it's no longer used in the codebase, marking it as deprecated * fix(migration-engine): corrected "EngineArgs.IntrospectParams" type * chore(internals): update snapshot * fix(migrate): pass schema path to "getDatabaseVersion" * feat(migrate): understood "getDatabaseVersion" * chore: removed comment * feat(migration-engine): temporarily removed support for "getDatabaseVersion" due to prisma/prisma-private#203 * test(integration-tests): close db connection after setting up sql to avoid exhausting the max_connection with idle connections (on my computer = 100) It was already done for SQL Server but not for PostgreSQL, MySQL, MariaDB * test(integration-tests): start and stop the engine for each test The ME will keep connections until it's closed, which means that we could exhaust the max_con number of connection open for postgresql see https://prisma-company.slack.com/archives/C02FNFLDUS3/p1671204843482509 * chore: update snapshot * feat: shut down migration-engine once "introspect()" has returned * fix: "should fail when db is empty" sqlite test, changed P1003 in favor of P4001 * chore: add comments about sqlite * fix engine.stop() * feat: kill the migration-engine after a successful or failing introspection * feat: fix artificial-panic test * feat: fix incomplete-schemas test * feat(migrate): add support for both P1003 and P4001, add "postgresql - missing database" testcd '/Users/jkomyno/work/prisma/prisma/packages/migrate' * chore(deps): update engines to 4.9.0-33.bb177fac1c08b8561c02b04d9ad51a31981cd8a3 * Revert "chore(deps): update engines to 4.9.0-33.bb177fac1c08b8561c02b04d9ad51a31981cd8a3" This reverts commit fcbd3bc. * chore: undo test.skip * chore: nit on enginesVersion * chore: removed outdated comment * feat: add missing types from c2d32ee * chore: removed useless file * chore: removed redundant engine.stop() * chore: removed redundant engine.stop() * chore: recovered engine.stop() in introspection.test.ts * [skip ci] chore: nit comment Co-authored-by: Joël Galeran <[email protected]> * chore: add issue Co-authored-by: Joël Galeran <[email protected]> Co-authored-by: Prismo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration PR for #3486.