-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(qe): Capture query logs and return with response #3112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrensmith
force-pushed
the
log-capture
branch
from
August 10, 2022 14:41
887db40
to
4553b8d
Compare
aqrln
reviewed
Aug 11, 2022
aqrln
reviewed
Aug 11, 2022
aqrln
reviewed
Aug 11, 2022
garrensmith
force-pushed
the
log-capture
branch
from
August 15, 2022 09:03
c04d8c2
to
e66186a
Compare
aqrln
reviewed
Aug 15, 2022
This comment was marked as outdated.
This comment was marked as outdated.
When tracing is disabled, we set the trace parent to I don't know if using the transparent for grouping the logs is the best course of action, as 9 times out of 10 the transparent is going to be a static value. |
garrensmith
force-pushed
the
log-capture
branch
2 times, most recently
from
October 6, 2022 14:18
67a1efc
to
8c0827b
Compare
miguelff
force-pushed
the
log-capture
branch
from
December 12, 2022 15:55
8c0827b
to
4db84c2
Compare
Client PR: prisma/prisma#16748 |
… been added to the capturer
This is a hack that will be removed soon, it's just to test some of the behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in https://github.com/prisma/client-planning/issues/158
The Query engine server can use a new capture tracer that can
capture the query logs for a Prisma Operation and return them
as part of the response.
For the logs to be captured, start up the query engine with the flag
--enable-logs-in-response
.For each query pass in a traceparent in the
traceparent
header. The trace-id is used to keep track of the relevant logs.For each request you want a log response back add the header:
CAPTURE_LOGS: true
.The response will then look like this: