Skip to content

Commit

Permalink
Merge pull request #3110 from prisma/fix/dmmf-test
Browse files Browse the repository at this point in the history
  • Loading branch information
millsp authored Aug 8, 2022
2 parents b3444d6 + 8dd177a commit 2920a97
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
4 changes: 2 additions & 2 deletions query-engine/query-engine-node-api/src/engine.rs
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ impl QueryEngine {
let dispatcher = self.logger.dispatcher();

async_panic_to_js_error(async {
let span = tracing::info_span!("prisma:engine:connect", user_facing = true);
let span = tracing::info_span!("prisma:engine:connect");
let _ = set_parent_context_from_json_str(&span, &trace);

let mut inner = self.inner.write().await;
Expand Down Expand Up @@ -284,7 +284,7 @@ impl QueryEngine {
let dispatcher = self.logger.dispatcher();

async_panic_to_js_error(async {
let span = tracing::info_span!("prisma:engine:disconnect", user_facing = true);
let span = tracing::info_span!("prisma:engine:disconnect");
let _ = set_parent_context_from_json_str(&span, &trace);

async {
Expand Down
4 changes: 0 additions & 4 deletions query-engine/query-engine/src/opt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,6 @@ pub struct PrismaOpt {
#[structopt(long, default_value)]
pub open_telemetry_endpoint: String,

/// JSON object for tracing headers such as the traceparent
#[structopt(long, default_value = "{}")]
pub tracing_headers: String,

#[structopt(subcommand)]
pub subcommand: Option<Subcommand>,
}
Expand Down
5 changes: 2 additions & 3 deletions query-engine/query-engine/src/server/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use datamodel::common::preview_features::PreviewFeature;
use hyper::service::{make_service_fn, service_fn};
use hyper::{header::CONTENT_TYPE, Body, HeaderMap, Method, Request, Response, Server, StatusCode};
use opentelemetry::{global, propagation::Extractor, Context};
use query_core::{schema::QuerySchemaRenderer, set_parent_context_from_json_str, TxId};
use query_core::{schema::QuerySchemaRenderer, TxId};
use query_core::{MetricFormat, MetricRegistry};
use request_handlers::{dmmf, GraphQLSchemaRenderer, GraphQlHandler, TxInput};
use serde_json::json;
Expand Down Expand Up @@ -64,8 +64,7 @@ pub async fn setup(opts: &PrismaOpt, metrics: MetricRegistry) -> PrismaResult<St
let config = opts.configuration(false)?.subject;
config.validate_that_one_datasource_is_provided()?;

let span = tracing::info_span!("prisma:engine:connect", user_facing = true);
let _ = set_parent_context_from_json_str(&span, &(opts.tracing_headers));
let span = tracing::info_span!("prisma:engine:connect");

let enable_itx = config
.preview_features()
Expand Down

0 comments on commit 2920a97

Please sign in to comment.