fix: pass CLIENT_FOUND_ROWS #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the behaviour of the affected count returned for mutations (UPDATE/INSERT etc). It makes MySQL returns the FOUND rows instead of the AFFECTED rows. Without this, MySQL returns 0 affected row when performing a noop update. This breaks the QueryEngine when performing nested connects which expect the update to have had happened.
Weakky
added a commit
to prisma/prisma-engines
that referenced
this pull request
Feb 7, 2023
When performing a noop update on MySQL & MongoDB, the returned "affected count" by the updateMany mutation was 0. This was breaking nested connect mutations which expect the mutation to have happened. MySQL & MongoDB were affected by this. This commit updates mysql_async (prisma/mysql_async#1) so that it passes the CLIENT_FOUND_ROWS flag. This changes the behaviour of the affected count returned for mutations (UPDATE/INSERT etc). It makes MySQL return the FOUND rows instead of the AFFECTED rows. It also updates the logic on MongoDB to rely on the `matched_count` instead of the `modified_count`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behaviour of the affected count returned for mutations (UPDATE/INSERT etc). It makes MySQL return the FOUND rows instead of the AFFECTED rows. Without this, MySQL returns 0 affected row when performing a noop update. This breaks the QueryEngine when performing nested connects which expect the update to have had happened.
You can read more about it here https://dev.mysql.com/doc/refman/8.0/en/information-functions.html.