fix(LS): rename where map doesn't exist (#1780)

* fix & test rename where map doesn't exist yet
prisma · Jul 16, 2024 · 45aa838 · 45aa838
1 parent 7891458
commit 45aa838
Show file tree

Hide file tree

Showing 3 changed files with 85 additions and 18 deletions.
diff --git a/packages/language-server/src/__test__/rename/multi-file.test.ts b/packages/language-server/src/__test__/rename/multi-file.test.ts
@@ -93,7 +93,7 @@ test('rename model', async () => {
   `)
 })
 
-test('rename field', async () => {
+test('rename field - map exists', async () => {
   const helper = await getMultifileHelper('user-posts')
   const user = helper.file('User.prisma')
 
@@ -168,3 +168,68 @@ test('rename field', async () => {
     }
   `)
 })
+
+test('rename field - map does not exist', async () => {
+  const helper = await getMultifileHelper('user-posts')
+  const user = helper.file('User.prisma')
+
+  const response = handleRenameRequest(helper.schema, user.textDocument, {
+    textDocument: {
+      uri: user.uri,
+    },
+    position: user.lineContaining('name  String').characterAfter('na'),
+    newName: 'fullName',
+  })
+
+  expect(response).toMatchInlineSnapshot(`
+    {
+      "changes": {
+        "file:///user-posts/User.prisma": [
+          {
+            "newText": "fullName",
+            "range": {
+              "end": {
+                "character": 8,
+                "line": 3,
+              },
+              "start": {
+                "character": 4,
+                "line": 3,
+              },
+            },
+          },
+          {
+            "newText": " @map("name")",
+            "range": {
+              "end": {
+                "character": 16,
+                "line": 3,
+              },
+              "start": {
+                "character": 16,
+                "line": 3,
+              },
+            },
+          },
+        ],
+      },
+    }
+  `)
+
+  expect(helper.applyChanges(response?.changes)).toMatchInlineSnapshot(`
+    {
+      "file:///user-posts/User.prisma": "/// This is the user of the platform
+    model User {
+        id    String @id @default(uuid()) @map("_id")
+        fullName  String @map("name")
+        email String
+        posts Post[]
+
+        address Address
+
+        favouriteAnimal FavouriteAnimal
+    }
+    ",
+    }
+  `)
+})
diff --git a/packages/language-server/src/__test__/rename/single-file.test.ts b/packages/language-server/src/__test__/rename/single-file.test.ts
@@ -369,8 +369,8 @@ describe('Rename', () => {
             {
               newText: ' @map("Album")',
               range: {
-                start: { line: 136, character: 33 },
-                end: { line: 136, character: 33 },
+                start: { line: 136, character: 34 },
+                end: { line: 136, character: 34 },
               },
             },
           ],
@@ -416,8 +416,8 @@ describe('Rename', () => {
             {
               newText: ' @map("authorId")',
               range: {
-                start: { line: 4, character: 16 },
-                end: { line: 4, character: 16 },
+                start: { line: 4, character: 17 },
+                end: { line: 4, character: 17 },
               },
             },
             {
@@ -458,8 +458,8 @@ describe('Rename', () => {
             {
               newText: ' @map("title")',
               range: {
-                start: { line: 17, character: 16 },
-                end: { line: 17, character: 16 },
+                start: { line: 17, character: 17 },
+                end: { line: 17, character: 17 },
               },
             },
             {
@@ -492,8 +492,8 @@ describe('Rename', () => {
             {
               newText: ' @map("humanId")',
               range: {
-                start: { line: 25, character: 13 },
-                end: { line: 25, character: 13 },
+                start: { line: 25, character: 14 },
+                end: { line: 25, character: 14 },
               },
             },
             {
@@ -567,8 +567,8 @@ describe('Rename', () => {
             {
               newText: ' @map("A_VARIANT_WITH_UNDERSCORES")',
               range: {
-                start: { line: 8, character: 27 },
-                end: { line: 8, character: 27 },
+                start: { line: 8, character: 28 },
+                end: { line: 8, character: 28 },
               },
             },
             {

diff --git a/packages/language-server/src/lib/code-actions/rename.ts b/packages/language-server/src/lib/code-actions/rename.ts
@@ -155,7 +155,7 @@ export function printLogMessage(
 }
 
 function insertInlineRename(currentName: string, line: Line): EditsMap {
-  const character = lastNoNewlineCharacter(line.untrimmedText)
+  const character = lastNewLineCharacter(line.untrimmedText)
   return {
     [line.document.uri]: [
       {
@@ -175,13 +175,15 @@ function insertInlineRename(currentName: string, line: Line): EditsMap {
   }
 }
 
-function lastNoNewlineCharacter(lineText: string) {
-  for (let i = lineText.length - 1; i >= 0; i--) {
-    if (lineText[i] !== '\n' && lineText[i] !== '\r') {
-      return i
-    }
+function lastNewLineCharacter(lineText: string) {
+  const i = lineText.length - 1
+  if (lineText[i] === '\n' && lineText[i - 1] === '\r') {
+    return i - 1
+  } else if (lineText[i] === '\n') {
+    return i
+  } else {
+    return 0
   }
-  return 0
 }
 
 function insertMapBlockAttribute(oldName: string, block: Block): EditsMap {