Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address reviewer comments by @drmattg #64

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Conversation

jeffreyhanson
Copy link
Collaborator

This PR aims to address the issues raised by @DrMattG. Specifically, it adds links for citations in the README (#58) and adds more information about the versining to wdpa_fetch() (#59). When you get a chance @DrMattG, could you please take a look and let me know if this PR satifies your concerns?

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #64 (bb04582) into master (d075533) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files          10       10           
  Lines         517      517           
=======================================
  Hits          504      504           
  Misses         13       13           
Impacted Files Coverage Δ
R/wdpa_fetch.R 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jeffreyhanson
Copy link
Collaborator Author

Awesome - thanks for approving the PR @DrMattG, I'll merge it now.

@jeffreyhanson jeffreyhanson merged commit 81b47ae into master Oct 3, 2022
@jeffreyhanson jeffreyhanson deleted the drmattg-review branch October 3, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants