Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation of conditional request support #11

Merged
merged 91 commits into from
Aug 29, 2020
Merged

implementation of conditional request support #11

merged 91 commits into from
Aug 29, 2020

Conversation

prince-chrismc
Copy link
Owner

@prince-chrismc prince-chrismc commented Aug 27, 2020 •
edited
Loading

Follow up from #10

closes #14

  • Correcting some original mistakes
  • heavily refactored back-end to accommodate new functionality
    • added clang-formatting support
  • Minor teak to add support to front-end
  • add tests to front end for passing etag
  • Missing header include guards
  • Several files are missing EOL
  • Fill router
  • response builder needs a cpp
  • run linting

@prince-chrismc
👷 adding a user database to track last modified
564b6fe
@prince-chrismc
📍 expanding api definition
9dd830a
@prince-chrismc
📚 adding more support for condition requests
46beaca
@prince-chrismc
playing with how to add etag unique identifer
e5a1433
@prince-chrismc
🚿 improving clang tidy target
fda4e4a
@prince-chrismc
renames to handlers user routes
25c503e
@prince-chrismc
fixing build + sorting linting
4b44ce5
@prince-chrismc
outline for new encoders
a3b7f4f
@prince-chrismc
adding encoders to tests
a1e66e3
@prince-chrismc
firgured our how to test the sha256
41d3826 
https://www.di-mgt.com.au/sha_testvectors.html
@prince-chrismc
Adding encoders for etag
f34fb33
@prince-chrismc
Update CMakeLists.txt
fd340da
@prince-chrismc
Quick pass implementing etag
ffc8365
@prince-chrismc
first draft of a user::database
af4b5af
@prince-chrismc
refactor user db improved api
afb70e3
@prince-chrismc
adding tests for last modified on remove user
a799e78
@prince-chrismc
correcting description
2169653
@prince-chrismc
test to check the etag value
3e0cbf0
@prince-chrismc
making sure remove happens within a reasonable timeframe
f6de698 
switching to unordered map since its slightly more performant for my use cases
@prince-chrismc
adding alias for restinio types
441547f
@prince-chrismc
refactor handler types
cc54201 
to make my life easier
@prince-chrismc
🚿 adding an "top level" linting target
d292bdc 
namely inspired by https://github.com/zemasoft/clangformat-cmake/blob/17cf929768ffea5b087cde3ab79e6ef48e9838e2/cmake/ClangFormat.cmake
@prince-chrismc
more improvements to the clang-tidy targets
c6b8322
@prince-chrismc
🚿 adding clang-format, improve clang-tidy
906ee19
@prince-chrismc
Merge branch 'master' of https://github.com/prince-chrismc/user-manag…
5acc9e0 
…ement into last-modified
@prince-chrismc
removing conditional from CORS requests
9c50243
@prince-chrismc
coverting routes to use db
34c16e5
@prince-chrismc
fixing tests
5556b13
@prince-chrismc
sanity check oh um list
2943111
@prince-chrismc
testing GET user id
71ef410
prince-chrismc
prince-chrismc commented Aug 27, 2020
View reviewed changes
Copy link
Owner Author

@prince-chrismc prince-chrismc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more TODOs

backend/test/CMakeLists.txt Outdated Show resolved Hide resolved
web-app/src/components/App.js Outdated Show resolved Hide resolved
.github/workflows/ccpp.yml
@@ -31,7 +31,7 @@ jobs:
uses: actions/cache@v2
with:
path: ~/.conan/data
key: ${{ runner.os }}-${{ hashFiles('**/conanfile.txt') }}
key: ${{ runner.os }}-${{ hashFiles('**/conanfile.py') }}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may cause the cause to be invalided for cosmetic changes

backend/CMakeLists.txt Outdated Show resolved Hide resolved
backend/src/handlers/user_routes.cpp Outdated Show resolved Hide resolved
backend/src/handlers/user_routes.cpp Outdated Show resolved Hide resolved
backend/src/handlers/utility/response_builder.hpp Outdated Show resolved Hide resolved
backend/src/handlers/utility/response_builder.hpp Outdated Show resolved Hide resolved
web-app/src/components/operations/Add.js Outdated Show resolved Hide resolved
@prince-chrismc prince-chrismc added this to the 1.0.0-dev.1 milestone Aug 28, 2020
@prince-chrismc
Copy link
Owner Author

https://unix.stackexchange.com/a/161853

@prince-chrismc prince-chrismc merged commit f3a7f24 into master Aug 29, 2020
@prince-chrismc prince-chrismc deleted the last-modified branch August 29, 2020 21:26
@prince-chrismc prince-chrismc added api This issue or pull request pertains to the API common to all components back-end This issue or pull request pertains to the back-end component enhancement Issue that adds a new feature front-end This issue or pull request pertains to the front-end component labels Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api This issue or pull request pertains to the API common to all components back-end This issue or pull request pertains to the back-end component enhancement Issue that adds a new feature front-end This issue or pull request pertains to the front-end component
Projects
None yet
Milestone
1.0.0-dev.1
Development

Successfully merging this pull request may close these issues.

add new user API is not correctly supported
1 participant
@prince-chrismc